This is an archive of the discontinued LLVM Phabricator instance.

Differential D122570

[libcxx] [test] Include header for strverscmp
ClosedPublic

Authored by jwakely on Mar 28 2022, 4:13 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG46d9a6ebd615: [libcxx] [test] Include header for strverscmp

Diff Detail

Event Timeline

jwakely created this revision.Mar 28 2022, 4:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 4:13 AM
jwakely requested review of this revision.Mar 28 2022, 4:13 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 28 2022, 4:13 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B156524: Diff 418539.Mar 28 2022, 5:35 AM
ldionne accepted this revision.Mar 28 2022, 11:19 AM

LGTM with comment added!

libcxx/test/support/platform_support.h
46
This revision is now accepted and ready to land.Mar 28 2022, 11:19 AM
jwakely updated this revision to Diff 418695.Mar 28 2022, 1:58 PM

Add comment to #include

jwakely updated this revision to Diff 418696.Mar 28 2022, 1:59 PM

Add comment to #include (with the right attachment t his time!)

jwakely marked an inline comment as done.Mar 28 2022, 2:00 PM
jwakely added inline comments.
libcxx/test/support/platform_support.h
46

Oh, I thought I'd done exactly that ... I must have not committed that part and then reset the tree. Added now.

Harbormaster completed remote builds in B156636: Diff 418696.Mar 28 2022, 3:35 PM
jwakely marked an inline comment as done.May 18 2022, 3:02 AM

I don't have commit access, could somebody push this on behalf of Jonathan Wakely <jwakely@redhat.com> please?

Closed by commit rG46d9a6ebd615: [libcxx] [test] Include header for strverscmp (authored by jwakely, committed by bkramer). · Explain WhyMay 18 2022, 5:37 AM
This revision was automatically updated to reflect the committed changes.
bkramer added a commit: rG46d9a6ebd615: [libcxx] [test] Include header for strverscmp.

Revision Contents

PathSize
libcxx/
test/
support/
4 lines

Diff 418696

libcxx/test/support/platform_support.h

Show All 36 Lines
#include <locale> #include <locale>
#include <string> #include <string>
#if defined(_WIN32) #if defined(_WIN32)
# include <io.h> // _mktemp_s # include <io.h> // _mktemp_s
#else #else
# include <unistd.h> // close # include <unistd.h> // close
#endif #endif
#if defined(_CS_GNU_LIBC_VERSION)
# include <string.h> // strverscmp
ldionneUnsubmitted
Done
ReplyInline Actions
#if defined(_CS_GNU_LIBC_VERSION)
- # include <string.h>
+ # include <string.h> // strverscmp
#endif
ldionne:
jwakelyAuthorUnsubmitted
Done
ReplyInline Actions

Oh, I thought I'd done exactly that ... I must have not committed that part and then reset the tree. Added now.

jwakely: Oh, I thought I'd done exactly that ... I must have not committed that part and then reset the…
#endif
#if defined(_NEWLIB_VERSION) && defined(__STRICT_ANSI__) #if defined(_NEWLIB_VERSION) && defined(__STRICT_ANSI__)
// Newlib provides this, but in the header it's under __STRICT_ANSI__ // Newlib provides this, but in the header it's under __STRICT_ANSI__
extern "C" { extern "C" {
int mkstemp(char*); int mkstemp(char*);
} }
#endif #endif
inline inline
▲ Show 20 Lines • Show All 46 Lines • Show Last 20 Lines