This is an archive of the discontinued LLVM Phabricator instance.

[lldb] correct comment in deterministic build test
Needs RevisionPublic

Authored by fanquake on Mar 28 2022, 3:38 AM.

Details

Reviewers
int3
Group Reviewers
Restricted Project
Summary

Since https://reviews.llvm.org/D103446, lld now also respects the ZERO_AR_DATE env var.

Diff Detail

Event Timeline

fanquake created this revision.Mar 28 2022, 3:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 3:38 AM
Herald added a subscriber: mgrang. · View Herald Transcript
fanquake requested review of this revision.Mar 28 2022, 3:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 3:38 AM
int3 added a subscriber: int3.EditedMar 28 2022, 6:07 PM

The underlying test is still using just ld64 though. I think a proper fix would be to use LLD if it's available as the host linker?

int3 requested changes to this revision.Apr 1 2022, 2:41 PM

Clearing queue

This revision now requires changes to proceed.Apr 1 2022, 2:41 PM