This is an archive of the discontinued LLVM Phabricator instance.

[clang] Make Driver tests pass when running with temp dir containing "crt"
ClosedPublic

Authored by thakis on Mar 27 2022, 1:12 PM.

Details

Summary

In a recent run, temp files got created in /tmp/lit-tmp-2wcrtcx1/foo-xxx.o.
Since the tmp path contained "crt", this made a few tests fail:
http://45.33.8.238/linux/72221/step_7.txt

Not allowing '/' as path of the file name prevents this.

Diff Detail

Event Timeline

thakis created this revision.Mar 27 2022, 1:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2022, 1:12 PM
thakis requested review of this revision.Mar 27 2022, 1:12 PM
hans accepted this revision.Mar 28 2022, 3:31 AM

lgtm

This revision is now accepted and ready to land.Mar 28 2022, 3:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 1:07 PM