This is an archive of the discontinued LLVM Phabricator instance.

Let clang-repl link privately against Clang components
ClosedPublic

Authored by aaronpuchert on Mar 27 2022, 12:10 PM.

Details

Summary

First of all, this is the convention: all other tools have their
dependencies private. While it does not have an effect on linking
(there is no linking against executables), it does have an effect
on exporting: having the targets private allows installing the tools
without the libraries in a statically linked build, or a build against
libclang-cpp.so.

Diff Detail

Event Timeline

aaronpuchert created this revision.Mar 27 2022, 12:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2022, 12:10 PM
Herald added a subscriber: mgorny. · View Herald Transcript
aaronpuchert requested review of this revision.Mar 27 2022, 12:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2022, 12:10 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
v.g.vassilev accepted this revision.Mar 28 2022, 9:07 AM

Thanks for the clarification! LGTM!

This revision is now accepted and ready to land.Mar 28 2022, 9:07 AM