This is an archive of the discontinued LLVM Phabricator instance.

Remove dead code in driver parsing -gsimple-template-names= options
ClosedPublic

Authored by probinson on Mar 25 2022, 1:18 PM.

Details

Summary

While -g[no-]simple-template-names is a driver option, the fancier
-gsimple-template-names={simple,mangled} option is cc1-only, so code
to handle it in the driver is dead.

Diff Detail

Event Timeline

probinson created this revision.Mar 25 2022, 1:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 1:18 PM
probinson requested review of this revision.Mar 25 2022, 1:18 PM

Relevant quote from Options.td:

def gsimple_template_names : Flag<["-"], "gsimple-template-names">, Group<g_flags_Group>;
def gsimple_template_names_EQ
    : Joined<["-"], "gsimple-template-names=">,
      HelpText<"Use simple template names in DWARF, or include the full "
               "template name with a modified prefix for validation">,
      Values<"simple,mangled">, Flags<[CC1Option, NoDriverOption]>;
def gno_simple_template_names : Flag<["-"], "gno-simple-template-names">,
                                Group<g_flags_Group>;
dblaikie accepted this revision.Mar 25 2022, 1:20 PM

oh, fair - yeah, if the tests pass, sounds good to me.

This revision is now accepted and ready to land.Mar 25 2022, 1:20 PM

+cfe-commits; that should have happened automatically?

This revision was landed with ongoing or failed builds.Mar 25 2022, 1:23 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2022, 1:23 PM