This is an archive of the discontinued LLVM Phabricator instance.

Pass -disable-llvm-passes to avoid running llvm passes
ClosedPublic

Authored by ahatanak on Mar 24 2022, 12:18 PM.

Details

Summary

It doesn't seem that clang/test/CodeGenCXX/nrvo.cpp needs llvm optimization passes.

Diff Detail

Event Timeline

ahatanak created this revision.Mar 24 2022, 12:18 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 24 2022, 12:18 PM
ahatanak requested review of this revision.Mar 24 2022, 12:18 PM
Izaron accepted this revision.EditedMar 26 2022, 4:40 AM

Hi! I don't actually know much about llvm passes, but I see that the LLVM IR output is much more understandable now, thanks! It will look nicer when I rebase my patch D119792 on top of this (I just checked the diff without llvm passes)

This revision is now accepted and ready to land.Mar 26 2022, 4:40 AM

Yes, this test was susceptible to changes made to llvm passes and the pass pipeline.

xbolva00 added inline comments.
clang/test/CodeGenCXX/nrvo.cpp
2

Do you need -O1 at all?

This revision was automatically updated to reflect the committed changes.

You should answer any review comments before any commit.

Sorry, I didn't notice you left a comment until after committing the patch. I agree that -O1 can be removed.