This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] don't break up #-style comment sections
ClosedPublic

Authored by krasimir on Mar 22 2022, 7:03 AM.

Details

Summary

Follow-up from https://github.com/llvm/llvm-project/commit/36d13d3f8adb3d1a6bae71370afa23d11a94dc78; https://reviews.llvm.org/D121451.

Restore the old behavior in situations where we use # as comments and long strings of #'s for comment sections.

Diff Detail

Event Timeline

krasimir created this revision.Mar 22 2022, 7:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 7:03 AM
krasimir requested review of this revision.Mar 22 2022, 7:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 7:03 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
krasimir edited projects, added Restricted Project; removed Restricted Project.Mar 22 2022, 7:03 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 7:03 AM
krasimir edited the summary of this revision. (Show Details)

I hit something like this today with some code which was

//#undef

I'm not sure I think that

// #undef

or

//# undef

is what I want either

MyDeveloperDay accepted this revision.Mar 22 2022, 7:26 AM
This revision is now accepted and ready to land.Mar 22 2022, 7:26 AM
This revision was landed with ongoing or failed builds.Mar 22 2022, 7:30 AM
This revision was automatically updated to reflect the committed changes.