This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Presburger] Fix a comment in the unittests
ClosedPublic

Authored by Cynthia-Here on Mar 21 2022, 6:11 PM.

Diff Detail

Event Timeline

Cynthia-Here created this revision.Mar 21 2022, 6:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2022, 6:11 PM
Cynthia-Here requested review of this revision.Mar 21 2022, 6:11 PM

Hi, thanks for this patch.

Usually, we prepend patches in the MLIR Presburger library with [MLIR][Presburger]. Can you also edit the title to just reflect what the patch is doing, i.e., fixing a comment in the unittests. It's not necessary to mention that this is your first patch. :)

You can also mention in the summary that the comment is in the unittests. Please use full grammar in the summary, i.e. put a full stop at the end of your sentence.

Cynthia-Here retitled this revision from Attempt to create the first patch - Comment modified to [MLIR][Presburger] Fix a comment in the unittests.Mar 22 2022, 8:40 AM
Cynthia-Here edited the summary of this revision. (Show Details)
Cynthia-Here edited the summary of this revision. (Show Details)
Cynthia-Here edited the summary of this revision. (Show Details)Mar 22 2022, 8:45 AM
Cynthia-Here edited the summary of this revision. (Show Details)Mar 22 2022, 8:49 AM
arjunp accepted this revision.Mar 22 2022, 8:53 AM
This revision is now accepted and ready to land.Mar 22 2022, 8:53 AM
This revision was automatically updated to reflect the committed changes.