This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo][NFC] Add a comment on the ordering of DILineInfo frames.
ClosedPublic

Authored by snehasish on Mar 18 2022, 1:36 PM.

Details

Summary

Add a comment to getFrame() to mention that frames are stored in
bottom-up, i.e. leaf to root in order of increasing index.

Diff Detail

Event Timeline

snehasish created this revision.Mar 18 2022, 1:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 1:36 PM
snehasish requested review of this revision.Mar 18 2022, 1:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2022, 1:36 PM

Sure, sounds OK!

tejohnson added inline comments.Mar 21 2022, 8:44 AM
llvm/include/llvm/DebugInfo/DIContext.h
94

Nit, missing comma after "leaf-to-root" to match prior comma. Or remove prior comma and put "i.e. leaf-to-root" in parentheses.

tejohnson accepted this revision.Mar 21 2022, 8:48 AM

(but lgtm otherwise)

This revision is now accepted and ready to land.Mar 21 2022, 8:48 AM

Update comment.

This revision was landed with ongoing or failed builds.Mar 21 2022, 10:42 AM
This revision was automatically updated to reflect the committed changes.