This is an archive of the discontinued LLVM Phabricator instance.

Differential D121865

[CodeGen] Inline _byteswap_* builtins.
ClosedPublic

Authored by efriedma on Mar 16 2022, 3:41 PM.

Details

Reviewers
rnk
mstorsjo
Commits
rG04ba344176b2: [CodeGen] Inline _byteswap_* builtins.
Summary

As discussed in D57915.

Fixes https://github.com/llvm/llvm-project/issues/39999 .

Diff Detail

Event Timeline

efriedma created this revision.Mar 16 2022, 3:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 3:41 PM
efriedma requested review of this revision.Mar 16 2022, 3:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 3:41 PM
rnk accepted this revision.Mar 16 2022, 4:15 PM

Huh. lgtm

This revision is now accepted and ready to land.Mar 16 2022, 4:15 PM
This revision was landed with ongoing or failed builds.Mar 16 2022, 4:19 PM
Closed by commit rG04ba344176b2: [CodeGen] Inline _byteswap_* builtins. (authored by efriedma). · Explain Why
This revision was automatically updated to reflect the committed changes.
efriedma added a commit: rG04ba344176b2: [CodeGen] Inline _byteswap_* builtins..
Harbormaster completed remote builds in B154727: Diff 416008.Mar 16 2022, 4:46 PM

Revision Contents

PathSize
clang/
lib/
CodeGen/
5 lines
test/
Headers/
8 lines

Diff 416019

clang/lib/CodeGen/CGBuiltin.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,926 Lines • ▼ Show 20 Lines case Builtin::BI__arithmetic_fence: {
Value *ArgValue = EmitScalarExpr(E->getArg(0)); Value *ArgValue = EmitScalarExpr(E->getArg(0));
if (isArithmeticFenceEnabled) if (isArithmeticFenceEnabled)
return RValue::get( return RValue::get(
Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType))); Builder.CreateArithmeticFence(ArgValue, ConvertType(ArgType)));
return RValue::get(ArgValue); return RValue::get(ArgValue);
} }
case Builtin::BI__builtin_bswap16: case Builtin::BI__builtin_bswap16:
case Builtin::BI__builtin_bswap32: case Builtin::BI__builtin_bswap32:
case Builtin::BI__builtin_bswap64: { case Builtin::BI__builtin_bswap64:
case Builtin::BI_byteswap_ushort:
case Builtin::BI_byteswap_ulong:
case Builtin::BI_byteswap_uint64: {
return RValue::get(emitUnaryBuiltin(*this, E, Intrinsic::bswap)); return RValue::get(emitUnaryBuiltin(*this, E, Intrinsic::bswap));
} }
case Builtin::BI__builtin_bitreverse8: case Builtin::BI__builtin_bitreverse8:
case Builtin::BI__builtin_bitreverse16: case Builtin::BI__builtin_bitreverse16:
case Builtin::BI__builtin_bitreverse32: case Builtin::BI__builtin_bitreverse32:
case Builtin::BI__builtin_bitreverse64: { case Builtin::BI__builtin_bitreverse64: {
return RValue::get(emitUnaryBuiltin(*this, E, Intrinsic::bitreverse)); return RValue::get(emitUnaryBuiltin(*this, E, Intrinsic::bitreverse));
} }
▲ Show 20 Lines • Show All 16,136 Lines • Show Last 20 Lines

clang/test/Headers/ms-arm64-intrin.cpp

// REQUIRES: aarch64-registered-target // REQUIRES: aarch64-registered-target
// RUN: %clang_cc1 -triple arm64-windows -O1 \ // RUN: %clang_cc1 -triple arm64-windows -O1 \
// RUN: -fms-compatibility -fms-compatibility-version=17.00 \ // RUN: -fms-compatibility -fms-compatibility-version=17.00 \
// RUN: -ffreestanding -fsyntax-only -Werror \ // RUN: -fsyntax-only -Werror \
// RUN: -isystem %S/Inputs/include %s -S -o - -emit-llvm 2>&1 \ // RUN: -isystem %S/Inputs/include %s -S -o - -emit-llvm 2>&1 \
// RUN: | FileCheck %s // RUN: | FileCheck %s
#include <intrin.h> #include <intrin.h>
void check_nop() { void check_nop() {
// CHECK: "nop" // CHECK: "nop"
__nop(); __nop();
} }
unsigned short check_byteswap_ushort(unsigned short val) { unsigned short check_byteswap_ushort(unsigned short val) {
// CHECK: call i16 @_byteswap_ushort(i16 noundef %val) // CHECK: call i16 @llvm.bswap.i16(i16 %val)
return _byteswap_ushort(val); return _byteswap_ushort(val);
} }
unsigned long check_byteswap_ulong(unsigned long val) { unsigned long check_byteswap_ulong(unsigned long val) {
// CHECK: call i32 @_byteswap_ulong(i32 noundef %val) // CHECK: call i32 @llvm.bswap.i32(i32 %val)
return _byteswap_ulong(val); return _byteswap_ulong(val);
} }
unsigned __int64 check_byteswap_uint64(unsigned __int64 val) { unsigned __int64 check_byteswap_uint64(unsigned __int64 val) {
// CHECK: call i64 @_byteswap_uint64(i64 noundef %val) // CHECK: call i64 @llvm.bswap.i64(i64 %val)
return _byteswap_uint64(val); return _byteswap_uint64(val);
} }