This is an archive of the discontinued LLVM Phabricator instance.

[LV] Fix typo in comment
ClosedPublic

Authored by sophia246 on Mar 16 2022, 1:42 AM.

Details

Summary

[LV] Fix typo in comment in LoopVectorize.cpp

Diff Detail

Event Timeline

sophia246 created this revision.Mar 16 2022, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 1:42 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
sophia246 requested review of this revision.Mar 16 2022, 1:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 16 2022, 1:42 AM
fhahn accepted this revision.Mar 16 2022, 1:48 AM
fhahn added a subscriber: fhahn.

LGTM, thanks. Can you please update the title to be a bit more descriptive? Maybe [LV] Fix typo in comment. Also, patches should generally be uploaded with full context (https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface if you are using the web interface)

This revision is now accepted and ready to land.Mar 16 2022, 1:48 AM
sophia246 retitled this revision from Fix spelling error to [LV]Fix spelling error .Mar 16 2022, 1:49 AM
dmgreen accepted this revision.Mar 16 2022, 1:49 AM

Oh yeah. Nice. I seem to do that a lot :)

LGTM

sophia246 retitled this revision from [LV]Fix spelling error to [LV] Fix typo in comment.Mar 16 2022, 1:53 AM
sophia246 edited the summary of this revision. (Show Details)
sophia246 updated this revision to Diff 415738.Mar 16 2022, 2:13 AM

upload patch with full context

sophia246 closed this revision.Mar 21 2022, 7:16 PM