This is an archive of the discontinued LLVM Phabricator instance.

[memprof] Add a test to verify callstack order.
ClosedPublic

Authored by snehasish on Mar 15 2022, 4:55 PM.

Details

Summary

We add to ensure that we are observing the correct callstack order in memprof
during symbolization. There was some confusion whether the order of
DIFrame objects were reversed but in reality the leaf function is at
index 0 so no code changes are required.

Diff Detail

Event Timeline

snehasish created this revision.Mar 15 2022, 4:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2022, 4:55 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
snehasish requested review of this revision.Mar 15 2022, 4:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2022, 4:55 PM
snehasish updated this revision to Diff 415641.Mar 15 2022, 5:00 PM

Rebase, lint and fix test invocation.

tejohnson added inline comments.Mar 15 2022, 5:03 PM
llvm/test/tools/llvm-profdata/memprof-inline.test
39

These are printed during a debug run of what tool and with what options?

snehasish updated this revision to Diff 415646.Mar 15 2022, 5:11 PM

Address comments.

snehasish marked an inline comment as done.Mar 15 2022, 5:12 PM

Updated the test documentation. PTAL, thanks!

This revision is now accepted and ready to land.Mar 15 2022, 5:13 PM
This revision was landed with ongoing or failed builds.Mar 16 2022, 10:11 AM
This revision was automatically updated to reflect the committed changes.