[libc++][tests] Use CMake provided paths for includes and libdir instead of hardcoding them
ClosedPublic
Actions

Authored by ldionne on Mar 15 2022, 7:55 AM.

Details

Reviewers

Group Reviewers

Restricted Project
Restricted Project

Commits

rG78669c4185e4: [libc++][tests] Use CMake provided paths for includes and libdir instead of…

Summary

In the new-style testing configurations, we were hardcoding paths to the
include and lib directories, which was incorrect but always went
unnoticed because the hardcoded values always happened to match the
actual value.

When using new-style configs with the bootstrapping build, this falls
appart -- and we never noticed this because the bootstrapping build was
still using old style configs.

This patch removes the %{install} substitution, which makes it too
tempting to hardcode installation paths, and it also switches the
bootstrapping build to actually using new-style configs like we
always intended to do.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	1,680 ms	libcxx CI AIX (32-bit) > ibm-libc++abi-shared-cfg-in.ibm-libc++abi-shared-cfg-in::catch_array_01.pass.cpp Script: -- : 'COMPILED WITH'; /opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/test/catch_array_01.pass.cpp --target=powerpc-ibm-aix -nostdinc++ -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix -D__LIBC_NO_CPP_MATH_OVERLOADS__ -DLIBCXXABI_NO_TIMER -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/test/support -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/src -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -nostdlib++ -L /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/lib -lc++ -lc++abi -Wl,-bbigtoc -o /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/Output/catch_array_01.pass.cpp.dir/t.tmp.exe
	1,830 ms	libcxx CI AIX (32-bit) > ibm-libc++abi-shared-cfg-in.ibm-libc++abi-shared-cfg-in::catch_array_02.pass.cpp Script: -- : 'COMPILED WITH'; /opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/test/catch_array_02.pass.cpp --target=powerpc-ibm-aix -nostdinc++ -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix -D__LIBC_NO_CPP_MATH_OVERLOADS__ -DLIBCXXABI_NO_TIMER -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/test/support -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/src -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -nostdlib++ -L /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/lib -lc++ -lc++abi -Wl,-bbigtoc -o /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/Output/catch_array_02.pass.cpp.dir/t.tmp.exe
	1,920 ms	libcxx CI AIX (32-bit) > ibm-libc++abi-shared-cfg-in.ibm-libc++abi-shared-cfg-in::catch_class_01.pass.cpp Script: -- : 'COMPILED WITH'; /opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/test/catch_class_01.pass.cpp --target=powerpc-ibm-aix -nostdinc++ -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix -D__LIBC_NO_CPP_MATH_OVERLOADS__ -DLIBCXXABI_NO_TIMER -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/test/support -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/src -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -nostdlib++ -L /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/lib -lc++ -lc++abi -Wl,-bbigtoc -o /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/Output/catch_class_01.pass.cpp.dir/t.tmp.exe
	1,900 ms	libcxx CI AIX (32-bit) > ibm-libc++abi-shared-cfg-in.ibm-libc++abi-shared-cfg-in::catch_class_02.pass.cpp Script: -- : 'COMPILED WITH'; /opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/test/catch_class_02.pass.cpp --target=powerpc-ibm-aix -nostdinc++ -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix -D__LIBC_NO_CPP_MATH_OVERLOADS__ -DLIBCXXABI_NO_TIMER -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/test/support -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/src -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -nostdlib++ -L /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/lib -lc++ -lc++abi -Wl,-bbigtoc -o /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/Output/catch_class_02.pass.cpp.dir/t.tmp.exe
	1,870 ms	libcxx CI AIX (32-bit) > ibm-libc++abi-shared-cfg-in.ibm-libc++abi-shared-cfg-in::catch_class_03.pass.cpp Script: -- : 'COMPILED WITH'; /opt/IBM/openxlC/17.1.0/bin/ibm-clang++_r /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/test/catch_class_03.pass.cpp --target=powerpc-ibm-aix -nostdinc++ -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix -D__LIBC_NO_CPP_MATH_OVERLOADS__ -DLIBCXXABI_NO_TIMER -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/test/support -I /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/libcxxabi/../libcxx/src -std=c++2b -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -Wno-exceptions -nostdlib++ -L /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/lib -lc++ -lc++abi -Wl,-bbigtoc -o /scratch/powerllvm/cpap8009/llvm-project/libcxx-ci/build/aix/Output/catch_class_03.pass.cpp.dir/t.tmp.exe
		View Full Test Results (187 Failed)