[libc++][NFC] Add TEST_HAS_NO_INCOMPLETE_RANGES.

[Mordante]

Summary

This avoids using an libc++ internal macro in our tests.

[philnik]

Wouldn't the easier option be to add // UNSUPPORTED: has-no-incomplete-ranges? It seems a bit overkill to me to add a new macro for a single test.

[Mordante]

In D121515#3377006, @philnik wrote:

Wouldn't the easier option be to add // UNSUPPORTED: has-no-incomplete-ranges? It seems a bit overkill to me to add a new macro for a single test.

I've considered that, but that would disable the entire test. Since the macro will be removed at some point I prefer to do it like this.
There are some other single occurrence macros where I want to discuss what the best approach will be. But I'll bring these macros up on Discord in the near future.

[philnik]

You said it yourself: The macro will be removed. We don't run any CI with _LIBCPP_HAS_NO_INCOMPLETE_RANGES, do we? If not I see no reason not do disable the entire test. It will only be disabled for those who don't ship ranges currently. I guess we should ask @ldionne what he thinks.

[ldionne]

In D121515#3377388, @philnik wrote:

You said it yourself: The macro will be removed. We don't run any CI with _LIBCPP_HAS_NO_INCOMPLETE_RANGES, do we? If not I see no reason not do disable the entire test. It will only be disabled for those who don't ship ranges currently. I guess we should ask @ldionne what he thinks.

We do run CI with HAS_NO_INCOMPLETE_RANGES in the no-experimental CI job. Furthermore, that configuration is actually the default that we ship -- in other words, as far as users are concerned, they only see the library with HAS_NO_INCOMPLETE_RANGES, so it's important to test it if we can (until we can get rid of it entirely).

libcxx/test/std/containers/views/span.cons/deduct.pass.cpp

void test_std_array() {
     const std::array<long, 5> arr = {4, 5, 6, 7, 8};
     std::span s{arr};
     ASSERT_SAME_TYPE(decltype(s), std::span<const long, 5>);
     assert(s.size() == arr.size());
     assert(s.data() == arr.data());
     }
 }
 
-#ifndef _LIBCPP_HAS_NO_INCOMPLETE_RANGES
+#ifndef TEST_HAS_NO_INCOMPLETE_RANGES
 void test_range_std_container() {
     {
     std::string str{"ABCDE"};
     std::span s{str};
     ASSERT_SAME_TYPE(decltype(s), std::span<char>);
     assert(s.size() == str.size());
     assert(s.data() == str.data());
     }
 
     {
     const std::string str{"QWERTYUIOP"};
     std::span s{str};
     ASSERT_SAME_TYPE(decltype(s), std::span<const char>);
     assert(s.size() == str.size());
     assert(s.data() == str.data());
     }
 }
-#endif // _LIBCPP_HAS_NO_INCOMPLETE_RANGES
+#endif // TEST_HAS_NO_INCOMPLETE_RANGES
 
 int main(int, char**)
 {
   test_iterator_sentinel();
   test_c_array();
   test_std_array();
 
-#ifndef _LIBCPP_HAS_NO_INCOMPLETE_RANGES
+#ifndef TEST_HAS_NO_INCOMPLETE_RANGES
   test_range_std_container();
-#endif // _LIBCPP_HAS_NO_INCOMPLETE_RANGES
+#endif // TEST_HAS_NO_INCOMPLETE_RANGES
 
   return 0;
 }

libcxx/test/support/test_macros.h

 #if defined(_LIBCPP_HAS_NO_FILESYSTEM_LIBRARY)
 #  define TEST_HAS_NO_FILESYSTEM_LIBRARY
 #endif
 
 #if defined(_LIBCPP_HAS_NO_FGETPOS_FSETPOS)
 #  define TEST_HAS_NO_FGETPOS_FSETPOS
 #endif
 
+#if defined(_LIBCPP_HAS_NO_INCOMPLETE_RANGES)
+#  define TEST_HAS_NO_INCOMPLETE_RANGES
+#endif
+
 #if defined(__GNUC__)
 #pragma GCC diagnostic pop
 #endif
 
 #endif // SUPPORT_TEST_MACROS_HPP