This is an archive of the discontinued LLVM Phabricator instance.

Differential D121502

[lldb] Use the debugger's asynchronous output stream for writing progress events.
ClosedPublic

Authored by JDevlieghere on Mar 11 2022, 5:34 PM.

Details

Reviewers
labath
jingham
Commits
rGc231deb79167: [lldb] Use the debugger's asynchronous output stream for progress events.
Summary

Use the debugger's asynchronous output stream for writing progress events.

Diff Detail

Event Timeline

JDevlieghere created this revision.Mar 11 2022, 5:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 11 2022, 5:34 PM
JDevlieghere requested review of this revision.Mar 11 2022, 5:34 PM
JDevlieghere added a parent revision: D121500: [lldb] Protect the debugger's output and error stream.
Harbormaster completed remote builds in B153864: Diff 414778.Mar 11 2022, 5:37 PM
JDevlieghere mentioned this in D121500: [lldb] Protect the debugger's output and error stream.Mar 11 2022, 5:41 PM
JDevlieghere updated this revision to Diff 414883.Mar 12 2022, 2:01 PM
JDevlieghere retitled this revision from [lldb] Use the debugger's output stream for writing in HandleProgressEvent to [lldb] Use the debugger's asynchronous output stream for writing progress events..
JDevlieghere edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B153952: Diff 414883.Mar 12 2022, 2:03 PM
labath accepted this revision.Mar 14 2022, 2:04 AM
This revision is now accepted and ready to land.Mar 14 2022, 2:04 AM
JDevlieghere removed a parent revision: D121500: [lldb] Protect the debugger's output and error stream.Mar 14 2022, 10:21 AM
Closed by commit rGc231deb79167: [lldb] Use the debugger's asynchronous output stream for progress events. (authored by JDevlieghere). · Explain WhyMar 14 2022, 10:31 AM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rGc231deb79167: [lldb] Use the debugger's asynchronous output stream for progress events..
Herald added a project: Restricted Project. · View Herald TranscriptMar 14 2022, 10:31 AM

Revision Contents

PathSize
lldb/
source/
Core/
5 lines

Diff 414778

lldb/source/Core/Debugger.cpp

Show First 20 Lines • Show All 991 Lines • ▼ Show 20 Lines
// Decide whether we actually are going to show the progress. This decision // Decide whether we actually are going to show the progress. This decision
// can change between iterations so check it inside the loop. // can change between iterations so check it inside the loop.
if (!GetShowProgress()) if (!GetShowProgress())
return; return;
// Determine whether the current output file is an interactive terminal with // Determine whether the current output file is an interactive terminal with
// color support. We assume that if we support ANSI escape codes we support // color support. We assume that if we support ANSI escape codes we support
// vt100 escape codes. // vt100 escape codes.
File &output = GetOutputFile(); StreamFile &output = GetOutputStream();
if (!output.GetIsInteractive() || !output.GetIsTerminalWithColors()) File &output_file = output.GetFile();
if (!output_file.GetIsInteractive() || !output_file.GetIsTerminalWithColors())
return; return;
// Print over previous line, if any. // Print over previous line, if any.
output.Printf("\r"); output.Printf("\r");
if (data->GetCompleted()) { if (data->GetCompleted()) {
// Clear the current line. // Clear the current line.
output.Printf("\x1B[2K"); output.Printf("\x1B[2K");
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines