This is an archive of the discontinued LLVM Phabricator instance.

[ASan] Added back @PLT to __asan_report_* calls to avoid compile errors.
ClosedPublic

Authored by kstoimenov on Mar 10 2022, 1:31 PM.

Diff Detail

Event Timeline

kstoimenov created this revision.Mar 10 2022, 1:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2022, 1:31 PM
kstoimenov requested review of this revision.Mar 10 2022, 1:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2022, 1:31 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka accepted this revision.Mar 10 2022, 1:40 PM
This revision is now accepted and ready to land.Mar 10 2022, 1:40 PM
This revision was landed with ongoing or failed builds.Mar 10 2022, 1:43 PM
This revision was automatically updated to reflect the committed changes.
MaskRay added a subscriber: MaskRay.EditedMar 10 2022, 1:47 PM

On x86-64, jmp foo is identical to jmp foo@PLT for GNU as/llvm mc newer than ~2018-02. Older assemblers may produce R_X86_64_PC32 and lead to a linker error is the symbol is defined in another DSO.

On x86-64, jmp foo is identical to jmp foo@PLT for GNU as/llvm mc newer than ~2018-02. Older assemblers may produce R_X86_64_PC32 and lead to a linker error is the symbol is defined in another DSO.

This patch fixed this bot failure: https://lab.llvm.org/buildbot/#/builders/165/builds/17497

Maybe they are using older compiler version?