[lldb] Add SBType::IsAggregateType

[kastiglione]

Summary

Add IsAggregateType to the SB API.

I'd like to use this from tests, and there are numerous other Is<X>Type
predicates on SBType.

[JDevlieghere]

LGTM

lldb/bindings/interface/SBType.i

public:
     * C: Returns false for all types.
     * C++: Return true only for C++11 scoped enums.
     * Objective-C: Returns false for all types.
     ") IsScopedEnumerationType;
     bool
     IsScopedEnumerationType ();
 
     %feature("docstring",
+    "Returns true if this type is an aggregate type.
+
+    Language-specific behaviour:
+
+    * C: Returns true for struct values, arrays, and vectors.
+    * C++: Same a C. Also includes class instances.
+    * Objective-C: Same as C. Also includes class instances.
+    ") IsAggregateType;
+    bool
+    IsAggregateType ();
+
+    %feature("docstring",
     "Returns a type that represents a pointer to this type.
 
     If the type system of the current language can't represent a pointer to this
     type or this type is invalid, an invalid `SBType` is returned.
 
     Language-specific behaviour:
 
     * C: Returns the pointer type of this type.

lldb/include/lldb/API/SBType.h

public:
   bool IsVectorType();
 
   bool IsTypedefType();
 
   bool IsAnonymousType();
 
   bool IsScopedEnumerationType();
 
+  bool IsAggregateType();
+
   lldb::SBType GetPointerType();
 
   lldb::SBType GetPointeeType();
 
   lldb::SBType GetReferenceType();
 
   lldb::SBType GetTypedefedType();
 

lldb/packages/Python/lldbsuite/test/lldbtest.py

def DebugSBType(self, type):
         """Debug print a SBType object, if traceAlways is True."""
         if not traceAlways:
             return
 
         err = sys.stderr
         err.write(type.GetName() + ":\n")
         err.write('\t' + "ByteSize        -> " +
                   str(type.GetByteSize()) + '\n')
+        err.write('\t' + "IsAggregateType   -> " +
+                  str(type.IsAggregateType()) + '\n')
         err.write('\t' + "IsPointerType   -> " +
                   str(type.IsPointerType()) + '\n')
         err.write('\t' + "IsReferenceType -> " +
                   str(type.IsReferenceType()) + '\n')
 
     def DebugPExpect(self, child):
         """Debug the spwaned pexpect object."""
         if not traceAlways:

lldb/source/API/SBType.cpp

 bool SBType::IsScopedEnumerationType() {
   LLDB_INSTRUMENT_VA(this);
 
   if (!IsValid())
     return false;
   return m_opaque_sp->GetCompilerType(true).IsScopedEnumerationType();
 }
 
+bool SBType::IsAggregateType() {
+  LLDB_INSTRUMENT_VA(this);
+
+  if (!IsValid())
+    return false;
+  return m_opaque_sp->GetCompilerType(true).IsAggregateType();
+}
+
 lldb::SBType SBType::GetFunctionReturnType() {
   LLDB_INSTRUMENT_VA(this);
 
   if (IsValid()) {
     CompilerType return_type(
         m_opaque_sp->GetCompilerType(true).GetFunctionReturnType());
     if (return_type.IsValid())
       return SBType(return_type);

lldb/test/API/python_api/type/TestTypeList.py

def test(self):
                 "Size of type_list from target.FindTypes('Task') query: %d" %
                 type_list.GetSize())
         # a second Task make be scared up by the Objective-C runtime
         self.assertTrue(len(type_list) >= 1)
         for type in type_list:
             self.assertTrue(type)
             self.DebugSBType(type)
             self.assertFalse(type.IsAnonymousType(), "Task is not anonymous")
+            self.assertTrue(type.IsAggregateType(), "Task is aggregate")
             for field in type.fields:
                 if field.name == "type":
                     for enum_member in field.type.enum_members:
                         self.assertTrue(enum_member)
                         self.DebugSBType(enum_member.type)
                 elif field.name == "my_type_is_nameless":
                     self.assertFalse(
                         field.type.IsAnonymousType(),
                         "my_type_is_nameless is not an anonymous type")
+                    self.assertTrue(field.type.IsAggregateType())
                 elif field.name == "my_type_is_named":
                     self.assertFalse(
                         field.type.IsAnonymousType(),
                         "my_type_is_named has a named type")
+                    self.assertTrue(field.type.IsAggregateType())
                 elif field.name == None:
                     self.assertTrue(
                         field.type.IsAnonymousType(),
                         "Nameless type is not anonymous")
 
         # Pass an empty string.  LLDB should not crash. :-)
         fuzz_types = target.FindTypes(None)
         fuzz_type = target.FindFirstType(None)
def test(self):
 
         # Get variable 'task_head'.
         task_head = frame0.FindVariable('task_head')
         self.assertTrue(task_head, VALID_VARIABLE)
         self.DebugSBValue(task_head)
         task_head_type = task_head.GetType()
         self.DebugSBType(task_head_type)
         self.assertTrue(task_head_type.IsPointerType())
+        self.assertFalse(task_head_type.IsAggregateType())
 
         self.assertEqual(task_head_type, task_pointer_type)
 
         # Get the pointee type of 'task_head'.
         task_head_pointee_type = task_head_type.GetPointeeType()
         self.DebugSBType(task_head_pointee_type)
 
         self.assertEqual(task_type, task_head_pointee_type)
 
         # We'll now get the child member 'id' from 'task_head'.
         id = task_head.GetChildMemberWithName('id')
         self.DebugSBValue(id)
         id_type = id.GetType()
         self.DebugSBType(id_type)
+        self.assertFalse(id_type.IsAggregateType())
 
         # SBType.GetBasicType() takes an enum 'BasicType'
         # (lldb-enumerations.h).
         int_type = id_type.GetBasicType(lldb.eBasicTypeInt)
         self.assertEqual(id_type, int_type)
 
         # Find 'myint_arr' and check the array element type.
         myint_arr = frame0.FindVariable('myint_arr')
         self.assertTrue(myint_arr, VALID_VARIABLE)
         self.DebugSBValue(myint_arr)
         myint_arr_type = myint_arr.GetType()
         self.DebugSBType(myint_arr_type)
         self.assertTrue(myint_arr_type.IsArrayType())
+        self.assertTrue(myint_arr_type.IsAggregateType())
         myint_arr_element_type = myint_arr_type.GetArrayElementType()
         self.DebugSBType(myint_arr_element_type)
         myint_type = target.FindFirstType('myint')
         self.DebugSBType(myint_type)
         self.assertEqual(myint_arr_element_type, myint_type)
 
         # Test enum methods. Requires DW_AT_enum_class which was added in Dwarf 4.
         if configuration.dwarf_version >= 4:
             enum_type = target.FindFirstType('EnumType')
             self.assertTrue(enum_type)
             self.DebugSBType(enum_type)
             self.assertFalse(enum_type.IsScopedEnumerationType())
+            self.assertFalse(enum_type.IsAggregateType())
 
             scoped_enum_type = target.FindFirstType('ScopedEnumType')
             self.assertTrue(scoped_enum_type)
             self.DebugSBType(scoped_enum_type)
             self.assertTrue(scoped_enum_type.IsScopedEnumerationType())
+            self.assertFalse(scoped_enum_type.IsAggregateType())
             int_scoped_enum_type = scoped_enum_type.GetEnumerationIntegerType()
             self.assertTrue(int_scoped_enum_type)
             self.DebugSBType(int_scoped_enum_type)
             self.assertEquals(int_scoped_enum_type.GetName(), 'int')
 
             enum_uchar = target.FindFirstType('EnumUChar')
             self.assertTrue(enum_uchar)
             self.DebugSBType(enum_uchar)
             int_enum_uchar = enum_uchar.GetEnumerationIntegerType()
             self.assertTrue(int_enum_uchar)
             self.DebugSBType(int_enum_uchar)
             self.assertEquals(int_enum_uchar.GetName(), 'unsigned char')