These tests don't seem specific to the debug mode, so it makes sense to
run them even when the debug mode is disabled. When we run with the debug
mode enabled, we'll get the out-of-bounds checking that this test seems
to be concerned with.
Details
Details
- Reviewers
Mordante ldionne - Group Reviewers
Restricted Project - Commits
- rG54c4c01553e1: [libc++] Enable format_to and vformat_to tests even outside of Debug mode
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
it makes sense to run them even when the debug mode is disabled
FWIW, that makes sense to me!
Comment Actions
I dug back in the development history, but I don't recall why I added this. It indeed doesn't seem to be required.
LGTM!