This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Enable format_to and vformat_to tests even outside of Debug mode
ClosedPublic

Authored by ldionne on Mar 8 2022, 11:51 AM.

Details

Summary

These tests don't seem specific to the debug mode, so it makes sense to
run them even when the debug mode is disabled. When we run with the debug
mode enabled, we'll get the out-of-bounds checking that this test seems
to be concerned with.

Diff Detail

Event Timeline

ldionne created this revision.Mar 8 2022, 11:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 11:51 AM
ldionne requested review of this revision.Mar 8 2022, 11:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 11:51 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript

it makes sense to run them even when the debug mode is disabled

FWIW, that makes sense to me!

Mordante accepted this revision as: Mordante.Mar 9 2022, 9:37 AM

it makes sense to run them even when the debug mode is disabled

FWIW, that makes sense to me!

I dug back in the development history, but I don't recall why I added this. It indeed doesn't seem to be required.
LGTM!

ldionne accepted this revision.Mar 9 2022, 9:38 AM
This revision is now accepted and ready to land.Mar 9 2022, 9:38 AM