[lldb] Removed scoped timer from ReadMemoryFromFileCache

[kastiglione]

Summary

ReadMemoryFromFileCache can be called at a high rate, and has fast execution.
Signposts for high rate & brief duration can have a negative impact on tracing;
emitting a high volume signposts can lead to blocking, affecting performance,
and total volume makes human review of the trace harder because of the noise.

[JDevlieghere]

LGTM. These are not meant to be on hot code paths.

[kastiglione]

This comment was removed by kastiglione.

[kastiglione]

Ignore previous comment, wrong diff.

lldb/source/Target/Target.cpp

if (m_platform_sp)
       return m_platform_sp->ModuleIsExcludedForUnconstrainedSearches(*this,
                                                                      module_sp);
   }
   return false;
 }
 
 size_t Target::ReadMemoryFromFileCache(const Address &addr, void *dst,
                                        size_t dst_len, Status &error) {
-  LLDB_SCOPED_TIMER();
   SectionSP section_sp(addr.GetSection());
   if (section_sp) {
     // If the contents of this section are encrypted, the on-disk file is
     // unusable.  Read only from live memory.
     if (section_sp->IsEncrypted()) {
       error.SetErrorString("section is encrypted");
       return 0;
     }