[lit] Fix failed tests to be recorded to .lit_test_times.txt

[picsel2]

Summary

Currently lit "forgets" that a test has failed, which the breaks the smart order option (probably the incremental option, too). This patch fixes the recording of failing tests by saving the negative time in .lit_test_times.txt.

[picsel2]

Ping.

[picsel2]

This is fixed with https://reviews.llvm.org/D130570 by now.

llvm/utils/lit/lit/TestTimes.py

for t in tests:
             continue
         if not t.suite.exec_root in times_by_suite:
             times_by_suite[t.suite.exec_root] = read_test_times(t.suite)
         time = -t.result.elapsed if t.isFailure() else t.result.elapsed
         # The "path" here is only used as a key into a dictionary. It is never
         # used as an actual path to a filesystem API, therefore we use '/' as
         # the canonical separator so that Unix and Windows machines can share
         # timing data.
-        times_by_suite[t.suite.exec_root]['/'.join(t.path_in_suite)] = t.result.elapsed
+        times_by_suite[t.suite.exec_root]['/'.join(t.path_in_suite)] = time
 
     for s, value in times_by_suite.items():
         try:
             path = os.path.join(s, '.lit_test_times.txt')
             with open(path, 'w') as time_file:
                 for name, time in value.items():
                     time_file.write(("%e" % time) + ' ' + name + '\n')
         except:
             lit_config.warning('Could not save test time: ' + path)
             continue

llvm/utils/lit/tests/Inputs/save-failed/fail.txt

+# RUN: false

llvm/utils/lit/tests/Inputs/save-failed/lit.cfg

+import lit.formats
+config.name = 'save-failed'
+config.suffixes = ['.txt']
+config.test_format = lit.formats.ShTest()
+config.test_source_root = None
+config.test_exec_root = None

llvm/utils/lit/tests/Inputs/save-failed/pass.txt

+# RUN: true

llvm/utils/lit/tests/save-failed.py

+# Check that failed tests are saved with negative test time to indicate failure
+
+# RUN: not %{lit} %{inputs}/save-failed
+# RUN: FileCheck %s < %{inputs}/save-failed/.lit_test_times.txt
+
+# CHECK-DAG: {{^[^-].*}} pass.txt
+# CHECK-DAG: {{^-.*}} fail.txt