This is an archive of the discontinued LLVM Phabricator instance.

Differential D120940

[lld-macho][nfc] Avoid using absolute addresses in cgprofile-icf.s
ClosedPublic

Authored by int3 on Mar 3 2022, 2:06 PM.

Details

Reviewers
lgrey
Group Reviewers
Restricted Project
Commits
rGf7547558c9f1: [lld-macho][nfc] Avoid using absolute addresses in cgprofile-icf.s
Summary

If we fix https://github.com/llvm/llvm-project/issues/54184, the
dyld_stub_binder symbol will get included in every output dylib. This
would cause the addresses of the other symbols to shift, breaking the
test as it currently stands. Let's make the test more flexible.

Diff Detail

Event Timeline

int3 created this revision.Mar 3 2022, 2:06 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 3 2022, 2:06 PM
int3 requested review of this revision.Mar 3 2022, 2:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 2:06 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
lgrey accepted this revision.Mar 3 2022, 2:10 PM

LGTM!

This revision is now accepted and ready to land.Mar 3 2022, 2:10 PM
Harbormaster completed remote builds in B152461: Diff 412836.Mar 3 2022, 2:21 PM
Closed by commit rGf7547558c9f1: [lld-macho][nfc] Avoid using absolute addresses in cgprofile-icf.s (authored by int3). · Explain WhyMar 3 2022, 4:00 PM
This revision was automatically updated to reflect the committed changes.
int3 added a commit: rGf7547558c9f1: [lld-macho][nfc] Avoid using absolute addresses in cgprofile-icf.s.

Revision Contents

PathSize
lld/
test/
MachO/
19 lines

Diff 412853

lld/test/MachO/cgprofile-icf.s

Show All 28 LinesA:
retq retq
.cg_profile A, B, 100 .cg_profile A, B, 100
.cg_profile A, C, 40 .cg_profile A, C, 40
.cg_profile C, D, 61 .cg_profile C, D, 61
.subsections_via_symbols .subsections_via_symbols
# CHECK: 0000000100000290 T A # CHECK: [[#%.16x,A:]] T A
# CHECK-NEXT: 0000000100000298 T C # CHECK-NEXT: [[#%.16x,A+8]] T C
# CHECK-NEXT: 0000000100000298 T D # CHECK-NEXT: [[#%.16x,A+8]] T D
# CHECK-NEXT: 00000001000002a0 T B # CHECK-NEXT: [[#%.16x,A+16]] T B
# NOICF: 0000000100000290 T A # NOICF: [[#%.16x,A:]] T A
# NOICF-NEXT: 0000000100000298 T B # NOICF-NEXT: [[#%.16x,A+8]] T B
# NOICF-NEXT: 00000001000002a0 T C # NOICF-NEXT: [[#%.16x,A+16]] T C
# NOICF-NEXT: 00000001000002a8 T D # NOICF-NEXT: [[#%.16x,A+24]] T D