Combine Mac and iOS target flags + light cleanup

Update function name and comment

yln@, looks like kubamracek@ hasn't been active recently, can you take a look? :)

Unconditional tool/util deps

In D147984#4264112, @hans wrote:

This broke the lit tests on Mac: LeakSanitizer-AddressSanitizer-x86_64 :: TestCases/Darwin/trampoline.mm
@lgrey who added that in D129385 maybe has some idea of what's going on?

I'll revert this for now.

Obviated by https://reviews.llvm.org/D145455

LGTM, thanks! Patched this in, and this fixes both the bug I mentioned on the other change as well as another one that was setting aliasee sizes to zero in STABS.

Ping :) Have you had a chance to think about alternatives?

In D144589#4148422, @int3 wrote:

1.5% seems kinda significant.

Patched it in and strip looks happy. Thanks!

Format

I'll merge this later today if nobody has objections.

Add operator| and operator|=, remove casting

enum -> enum class, remove memory tag aliases, clang-format

Updated with test now that https://reviews.llvm.org/D133126 has landed.

Comment on test, make test work on Linux

Added test. For some reason, I thought it was less practical than it ended up being, thanks for the suggestion.

Add test, clarify control flow

In D131624#3716584, @steven_wu wrote:

One thing missing is that in libLTO, the cached object is written to -object_path_lto using a hard-link. That is intentional to reduce the disk usage and it is faster than write a file buffer to output file. Might want to consider doing that in lld for future.

Changed to =default

In D129385#3639640, @lgrey wrote:

To be perfectly honest, I'm not sure since the objc runtime issues are masking everything else! I'm going to send a separate change to suppress those and get back to you :)

In D129385#3639506, @yln wrote:

Does this fix the check-lsan and check-asan targets (currently many tests are failing there on macOS Beta 13)?
Thanks!

Add assert

Add test for -final_output

Use finalOutput

LGTM!

+1, thanks!

In D117354#3262502, @thakis wrote:

I'd have one commit that does nothing but the file rename, then a 2nd commit that only moves unchanged functions around (both fine to commit directly), and then I'd rebase this on top of that so that it only shows the behavior change.

Having the file name be different from ELF and COFF is a bit unfortunate, but oh well.

Rebased on rename/function move

Format and rebase

Rebase

Ref - > pointer to const in addSym

Rebase

Update callsites

Comment round and format

Add time trace for parsing section, options edit

Variable renames, added missing newline

Restore accidentally stomped diff

Var renames, missing newline

Remove braces around single-line if