Page MenuHomePhabricator

lgrey (Leonard Grey)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 24 2021, 12:22 PM (52 w, 3 d)

Recent Activity

Fri, Jun 3

lgrey committed rGdd6bcdbf2171: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax… (authored by lgrey).
[Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax…
Fri, Jun 3, 9:12 AM · Restricted Project, Restricted Project
lgrey closed D126902: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax (NFC).
Fri, Jun 3, 9:12 AM · Restricted Project, Restricted Project
lgrey updated the diff for D126902: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax (NFC).

Add assert

Fri, Jun 3, 8:39 AM · Restricted Project, Restricted Project

Thu, Jun 2

lgrey added inline comments to D126902: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax (NFC).
Thu, Jun 2, 11:17 AM · Restricted Project, Restricted Project
lgrey requested review of D126902: [Attributes] Remove AttrSyntax and migrate uses to AttributeCommonInfo::Syntax (NFC).
Thu, Jun 2, 11:15 AM · Restricted Project, Restricted Project

Apr 1 2022

lgrey added inline comments to D122843: [lld-macho] Include output filename in UUID hash.
Apr 1 2022, 3:43 PM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 31 2022

lgrey committed rGa9e325116ca8: Add output filename to UUID hash (authored by lgrey).
Add output filename to UUID hash
Mar 31 2022, 3:52 PM · Restricted Project
lgrey closed D122843: [lld-macho] Include output filename in UUID hash.
Mar 31 2022, 3:52 PM · Restricted Project, Unknown Object (Project), Restricted Project
lgrey added inline comments to D122843: [lld-macho] Include output filename in UUID hash.
Mar 31 2022, 2:50 PM · Restricted Project, Unknown Object (Project), Restricted Project
lgrey updated the diff for D122843: [lld-macho] Include output filename in UUID hash.

Add test for -final_output

Mar 31 2022, 1:18 PM · Restricted Project, Unknown Object (Project), Restricted Project
lgrey added inline comments to D122843: [lld-macho] Include output filename in UUID hash.
Mar 31 2022, 12:11 PM · Restricted Project, Unknown Object (Project), Restricted Project
lgrey updated the diff for D122843: [lld-macho] Include output filename in UUID hash.

Use finalOutput

Mar 31 2022, 12:10 PM · Restricted Project, Unknown Object (Project), Restricted Project
lgrey requested review of D122843: [lld-macho] Include output filename in UUID hash.
Mar 31 2022, 12:04 PM · Restricted Project, Unknown Object (Project), Restricted Project

Mar 3 2022

lgrey accepted D120940: [lld-macho][nfc] Avoid using absolute addresses in cgprofile-icf.s.

LGTM!

Mar 3 2022, 2:10 PM · Restricted Project, Restricted Project, Unknown Object (Project)

Feb 17 2022

lgrey committed rGa52b9102d1f7: [lld-macho] Allow order files and call graph sorting to be used together (authored by lgrey).
[lld-macho] Allow order files and call graph sorting to be used together
Feb 17 2022, 11:20 AM
lgrey closed D117354: [lld-macho] Allow order files and call graph sorting to be used together.
Feb 17 2022, 11:20 AM · Restricted Project, Unknown Object (Project)

Feb 15 2022

lgrey accepted D119892: [lld-macho][nfc] Factor out callgraph parsing code.

+1, thanks!

Feb 15 2022, 2:48 PM · Restricted Project, Unknown Object (Project)

Feb 14 2022

lgrey added inline comments to D119612: [clang] Pass more flags to ld64.lld.
Feb 14 2022, 6:58 AM · Restricted Project

Jan 28 2022

lgrey added inline comments to D117354: [lld-macho] Allow order files and call graph sorting to be used together.
Jan 28 2022, 6:56 AM · Restricted Project, Unknown Object (Project)

Jan 25 2022

lgrey added a comment to D117354: [lld-macho] Allow order files and call graph sorting to be used together.

I'd have one commit that does nothing but the file rename, then a 2nd commit that only moves unchanged functions around (both fine to commit directly), and then I'd rebase this on top of that so that it only shows the behavior change.

Having the file name be different from ELF and COFF is a bit unfortunate, but oh well.

Jan 25 2022, 9:27 AM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D117354: [lld-macho] Allow order files and call graph sorting to be used together.

Rebased on rename/function move

Jan 25 2022, 9:27 AM · Restricted Project, Unknown Object (Project)
lgrey committed rGa5c9d717807f: [lld-macho] Move order file and call graph sorting into SectionPriorities (authored by lgrey).
[lld-macho] Move order file and call graph sorting into SectionPriorities
Jan 25 2022, 9:22 AM
lgrey committed rGf23d57a63266: [lld-macho] Rename CallGraphSort.{h,cpp} to SectionPriorities (authored by lgrey).
[lld-macho] Rename CallGraphSort.{h,cpp} to SectionPriorities
Jan 25 2022, 9:16 AM

Jan 21 2022

lgrey updated the diff for D117354: [lld-macho] Allow order files and call graph sorting to be used together.

Format and rebase

Jan 21 2022, 10:49 AM · Restricted Project, Unknown Object (Project)

Jan 20 2022

lgrey updated the diff for D117354: [lld-macho] Allow order files and call graph sorting to be used together.

Rebase

Jan 20 2022, 1:37 PM · Restricted Project, Unknown Object (Project)
lgrey added inline comments to D117354: [lld-macho] Allow order files and call graph sorting to be used together.
Jan 20 2022, 1:26 PM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D117354: [lld-macho] Allow order files and call graph sorting to be used together.

Ref - > pointer to const in addSym

Jan 20 2022, 1:19 PM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D117354: [lld-macho] Allow order files and call graph sorting to be used together.

Rebase

Jan 20 2022, 11:06 AM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D117354: [lld-macho] Allow order files and call graph sorting to be used together.

Update callsites

Jan 20 2022, 10:57 AM · Restricted Project, Unknown Object (Project)
lgrey added inline comments to D117354: [lld-macho] Allow order files and call graph sorting to be used together.
Jan 20 2022, 10:51 AM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D117354: [lld-macho] Allow order files and call graph sorting to be used together.

Comment round and format

Jan 20 2022, 10:50 AM · Restricted Project, Unknown Object (Project)

Jan 14 2022

lgrey requested review of D117354: [lld-macho] Allow order files and call graph sorting to be used together.
Jan 14 2022, 1:01 PM · Restricted Project, Unknown Object (Project)

Jan 11 2022

lgrey added inline comments to D112164: [lld-macho] Port CallGraphSort from COFF/ELF.
Jan 11 2022, 2:55 PM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Add time trace for parsing section, options edit

Jan 11 2022, 2:55 PM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D112160: [MachO] Port call graph profile section and directive.

Variable renames, added missing newline

Jan 11 2022, 1:44 PM · Restricted Project
lgrey updated the diff for D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Restore accidentally stomped diff

Jan 11 2022, 1:40 PM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Var renames, missing newline

Jan 11 2022, 1:34 PM · Restricted Project, Unknown Object (Project)

Dec 3 2021

lgrey requested review of D115055: [Support] Use final filename for Caching buffer identifier.
Dec 3 2021, 11:13 AM · Unknown Object (Project), Restricted Project

Oct 28 2021

lgrey updated the diff for D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Remove braces around single-line if

Oct 28 2021, 2:06 PM · Restricted Project, Unknown Object (Project)
lgrey added a comment to D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Windows Chrome got 3% on Speedometer from adding this. Locally on Chromium Mac, I'm seeing about the same thing (3.3% if I'm measuring correctly: means of 151 vs 156 with similar confidence intervals).

Oct 28 2021, 12:51 PM · Restricted Project, Unknown Object (Project)

Oct 27 2021

lgrey requested review of D112655: [CGProfile] Don't emit call graph profile edges with zero weight.
Oct 27 2021, 12:55 PM · Restricted Project
lgrey added a comment to D112160: [MachO] Port call graph profile section and directive.

Ping :)

Oct 27 2021, 7:26 AM · Restricted Project

Oct 21 2021

lgrey accepted D112238: [gn build] Make 'compiler-rt' depend on include dir.
Oct 21 2021, 11:28 AM · Restricted Project
lgrey updated the summary of D112160: [MachO] Port call graph profile section and directive.
Oct 21 2021, 9:42 AM · Restricted Project
lgrey updated the diff for D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Format

Oct 21 2021, 9:41 AM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Address comments: document CallGraphEntry struct, add time traces, only extract data if --call-graph-profile-sort, shuffle includes

Oct 21 2021, 9:38 AM · Restricted Project, Unknown Object (Project)

Oct 20 2021

lgrey updated the diff for D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Format

Oct 20 2021, 12:53 PM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D112164: [lld-macho] Port CallGraphSort from COFF/ELF.

Removed strays from test

Oct 20 2021, 11:19 AM · Restricted Project, Unknown Object (Project)
lgrey added inline comments to D112164: [lld-macho] Port CallGraphSort from COFF/ELF.
Oct 20 2021, 11:14 AM · Restricted Project, Unknown Object (Project)
lgrey requested review of D112164: [lld-macho] Port CallGraphSort from COFF/ELF.
Oct 20 2021, 11:12 AM · Restricted Project, Unknown Object (Project)
lgrey requested review of D112160: [MachO] Port call graph profile section and directive.
Oct 20 2021, 10:38 AM · Restricted Project

Oct 19 2021

lgrey added inline comments to D109109: [MC] Recursively calculate symbol offset.
Oct 19 2021, 11:30 AM · Restricted Project
lgrey updated the diff for D109109: [MC] Recursively calculate symbol offset.

Added comment, updated test

Oct 19 2021, 11:30 AM · Restricted Project

Oct 15 2021

lgrey added a comment to D109109: [MC] Recursively calculate symbol offset.

@MaskRay are you OK with this (with added FIXME) given the comment above? I think just removing the hack (and doing the migration work) isn't enough due to the issues I saw with relocations after removing it.

Oct 15 2021, 10:15 AM · Restricted Project

Sep 27 2021

lgrey added a comment to D109109: [MC] Recursively calculate symbol offset.

Oof! That does sound prohibitively difficult.

Sep 27 2021, 12:52 PM · Restricted Project

Sep 22 2021

lgrey added a comment to D109109: [MC] Recursively calculate symbol offset.

I think the MachO behavior described in https://bugs.llvm.org/show_bug.cgi?id=19203 is broken, but I still don't think that we can change this until we have a plan to deal with instances of the buggy pattern in the wild -- that's a much bigger issue than underlying bug.

Sep 22 2021, 7:24 AM · Restricted Project

Sep 14 2021

lgrey added a comment to D109109: [MC] Recursively calculate symbol offset.

lhames@ ping :) Any idea what the right approach is here?

Sep 14 2021, 1:27 PM · Restricted Project

Sep 10 2021

lgrey added a comment to D109109: [MC] Recursively calculate symbol offset.

So I tried this and the eh_frame thing is a real problem at link time. lld errors because the X86_64_RELOC_SUBTRACTOR ends up being local. The link succeeds in ld64, but produces a weirdly large binary.

Sep 10 2021, 2:48 PM · Restricted Project
lgrey added a comment to D109109: [MC] Recursively calculate symbol offset.

I think the root cause is: https://bugs.llvm.org/show_bug.cgi?id=19203. The proximate cause is https://github.com/llvm/llvm-project/blob/main/llvm/lib/MC/MCExpr.cpp#L820.

Sep 10 2021, 12:50 PM · Restricted Project

Sep 7 2021

lgrey edited reviewers for D109109: [MC] Recursively calculate symbol offset, added: MaskRay; removed: grosbach.
Sep 7 2021, 8:56 AM · Restricted Project

Sep 1 2021

lgrey requested review of D109109: [MC] Recursively calculate symbol offset.
Sep 1 2021, 4:22 PM · Restricted Project

Jul 22 2021

lgrey updated the diff for D106179: [lld-macho] Disambiguate bitcode files with the same name by archive name/offset in archive.

Typo fix

Jul 22 2021, 3:22 PM · Restricted Project, Unknown Object (Project)
lgrey added inline comments to D106179: [lld-macho] Disambiguate bitcode files with the same name by archive name/offset in archive.
Jul 22 2021, 1:07 PM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D106179: [lld-macho] Disambiguate bitcode files with the same name by archive name/offset in archive.

Reword comment, rm FIXME from test

Jul 22 2021, 1:07 PM · Restricted Project, Unknown Object (Project)
lgrey added inline comments to D106179: [lld-macho] Disambiguate bitcode files with the same name by archive name/offset in archive.
Jul 22 2021, 9:15 AM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D106179: [lld-macho] Disambiguate bitcode files with the same name by archive name/offset in archive.

Reword comment, refine test

Jul 22 2021, 9:15 AM · Restricted Project, Unknown Object (Project)

Jul 21 2021

lgrey updated the diff for D106179: [lld-macho] Disambiguate bitcode files with the same name by archive name/offset in archive.

Add test. Now ready for review :)

Jul 21 2021, 1:50 PM · Restricted Project, Unknown Object (Project)

Jul 16 2021

lgrey requested review of D106179: [lld-macho] Disambiguate bitcode files with the same name by archive name/offset in archive.
Jul 16 2021, 12:27 PM · Restricted Project, Unknown Object (Project)

Jul 15 2021

lgrey added inline comments to D105922: [lld-macho] Add LTO cache support.
Jul 15 2021, 9:25 AM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D105922: [lld-macho] Add LTO cache support.

thakis@ comments

Jul 15 2021, 9:23 AM · Restricted Project, Unknown Object (Project)

Jul 14 2021

lgrey added inline comments to D105922: [lld-macho] Add LTO cache support.
Jul 14 2021, 4:28 PM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D105922: [lld-macho] Add LTO cache support.
Jul 14 2021, 4:28 PM · Restricted Project, Unknown Object (Project)

Jul 13 2021

lgrey added inline comments to D105922: [lld-macho] Add LTO cache support.
Jul 13 2021, 11:23 AM · Restricted Project, Unknown Object (Project)
lgrey requested review of D105922: [lld-macho] Add LTO cache support.
Jul 13 2021, 11:21 AM · Restricted Project, Unknown Object (Project)

Jul 1 2021

lgrey added a comment to D105223: [lld-macho] Add support for LTO optimization level.

Does this test -O2 or --lto-O2? Do you need two files for checking lto, i.e. it inlines foo across two TUs?

Jul 1 2021, 7:35 AM · Unknown Object (Project), Restricted Project

Jun 30 2021

lgrey added inline comments to D105223: [lld-macho] Add support for LTO optimization level.
Jun 30 2021, 12:53 PM · Unknown Object (Project), Restricted Project
lgrey requested review of D105223: [lld-macho] Add support for LTO optimization level.
Jun 30 2021, 12:35 PM · Unknown Object (Project), Restricted Project

Jun 28 2021

lgrey updated the diff for D104919: [lld-macho] Preserve alignment for non-deduplicated cstrings.

Format

Jun 28 2021, 12:06 PM · Restricted Project, Unknown Object (Project)
lgrey added inline comments to D104919: [lld-macho] Preserve alignment for non-deduplicated cstrings.
Jun 28 2021, 9:15 AM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D104919: [lld-macho] Preserve alignment for non-deduplicated cstrings.

Test update

Jun 28 2021, 9:15 AM · Restricted Project, Unknown Object (Project)

Jun 25 2021

lgrey added inline comments to D104919: [lld-macho] Preserve alignment for non-deduplicated cstrings.
Jun 25 2021, 10:58 AM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D104919: [lld-macho] Preserve alignment for non-deduplicated cstrings.
  • Collapse class hierarchy so CStringSection handles the non dedup case
  • Make string hashing optional, and only do when deduping
  • Update commit message
Jun 25 2021, 10:57 AM · Restricted Project, Unknown Object (Project)
lgrey updated the diff for D104919: [lld-macho] Preserve alignment for non-deduplicated cstrings.

Rebase

Jun 25 2021, 8:20 AM · Restricted Project, Unknown Object (Project)
lgrey set the repository for D104919: [lld-macho] Preserve alignment for non-deduplicated cstrings to rG LLVM Github Monorepo.
Jun 25 2021, 7:37 AM · Restricted Project, Unknown Object (Project)
lgrey requested review of D104919: [lld-macho] Preserve alignment for non-deduplicated cstrings.
Jun 25 2021, 7:36 AM · Restricted Project, Unknown Object (Project)