This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Mark __wrap_iter's private constructors as explicit
ClosedPublic

Authored by Quuxplusone on Mar 3 2022, 12:47 PM.

Details

Summary

This is slightly more user-visible than D119894, because the user is
expected to touch __wrap_iter directly. But the affected ctors are
non-public, so the user was never expected to be actually calling them.
And I didn't intentionally omit this from D119894; I just didn't
think of it.

(Btw, I noticed this as a result of researching https://quuxplusone.github.io/blog/2022/03/03/why-isnt-vector-iterator-just-t-star/ )

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 12:47 PM
Quuxplusone requested review of this revision.Mar 3 2022, 12:47 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 3 2022, 12:47 PM
jloser added a subscriber: jloser.Mar 3 2022, 3:19 PM

Seems reasonable to me FWIW.

ldionne accepted this revision.Mar 4 2022, 8:34 AM
This revision is now accepted and ready to land.Mar 4 2022, 8:34 AM