This is an archive of the discontinued LLVM Phabricator instance.

Fix typo
ClosedPublic

Authored by jakevossen5 on Mar 3 2022, 12:04 PM.

Details

Summary

Saw a typo while checking out the docs, if you want me to split these up let me know and I can do it. You can see the SmallVector issue here: https://llvm.org/doxygen/SmallVector_8h.html

Diff Detail

Event Timeline

jakevossen5 created this revision.Mar 3 2022, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 12:04 PM
Herald added a subscriber: dexonsmith. · View Herald Transcript
jakevossen5 requested review of this revision.Mar 3 2022, 12:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2022, 12:04 PM

LGTM. Thanks for this contribution. Let me know if you want help to submit this patch to the github repo.

Note1: I don't usually review in this area, but this seems like a trivial patch to accept. Just responding to your post in twitter (https://twitter.com/jakevossen5/status/1509007485188812802?s=20&t=khx4DRCOepQ_wBpY2SDoIw). Have added @dexonsmith who seemed to be active in this part of the code, please wait a day before you merge.
Note2: Usually the recommendation is to upload the full context for patches. But I guess in this case it does not matter.
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

This revision is now accepted and ready to land.Mar 30 2022, 10:38 AM

RE: GitHub - pretty sure I don't have permissions to submit it to GitHub - last change I made was pushed by someone else (https://reviews.llvm.org/D103905), so I would appreciate the help!

RE: Note 2: my bad - will make sure I do that in the future!

This revision was landed with ongoing or failed builds.Mar 31 2022, 8:54 PM
This revision was automatically updated to reflect the committed changes.

The fix in README was already in, so merging the SmallVector doc change only. Thanks.