This is an archive of the discontinued LLVM Phabricator instance.

Differential D103905

fix typo in internals manual
ClosedPublic

Authored by jakevossen5 on Jun 8 2021, 9:00 AM.

Download Raw Diff

Details

Reviewers

Summary

You can see the typo here: https://clang.llvm.org/docs/InternalsManual.html#include-clang-basic-attr-td

Diff Detail

Event Timeline

jakevossen5 requested review of this revision.Jun 8 2021, 9:00 AM

jakevossen5 created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2021, 9:00 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

LGTM, thank you for the fix! Do you need me to land it on your behalf? If so, what name and email would you like me to use for patch attribution?

This revision is now accepted and ready to land.Jun 8 2021, 9:21 AM

Don't think I have permissions to that, so that would be great!

Name: Jake Vossen
Email: jake@vossen.dev

In D103905#2805700, @jakevossen5 wrote:

Don't think I have permissions to that, so that would be great!

Name: Jake Vossen
Email: jake@vossen.dev

Thanks -- I've commit on your behalf in 71fb98e0c1de97c8ba2aa3292447b0c5d0f248d5, thank you for the patch!

Harbormaster completed remote builds in B108225: Diff 350621.Jun 8 2021, 9:44 AM

jakevossen5 mentioned this in D120930: Fix typo.Mar 30 2022, 10:42 AM

Revision Contents

Path

Size

clang/

docs/

InternalsManual.rst

2 lines

Diff 350621

clang/docs/InternalsManual.rst

	Show First 20 Lines • Show All 2,824 Lines • ▼ Show 20 Lines
	`include/clang/Basic/Attr.td			`include/clang/Basic/Attr.td
	<https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/Attr.td>`_.			<https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/Attr.td>`_.
	This tablegen definition must derive from the ``Attr`` (tablegen, not			This tablegen definition must derive from the ``Attr`` (tablegen, not
	semantic) type, or one of its derivatives. Most attributes will derive from the			semantic) type, or one of its derivatives. Most attributes will derive from the
	``InheritableAttr`` type, which specifies that the attribute can be inherited by			``InheritableAttr`` type, which specifies that the attribute can be inherited by
	later redeclarations of the ``Decl`` it is associated with.			later redeclarations of the ``Decl`` it is associated with.
	``InheritableParamAttr`` is similar to ``InheritableAttr``, except that the			``InheritableParamAttr`` is similar to ``InheritableAttr``, except that the
	attribute is written on a parameter instead of a declaration. If the attribute			attribute is written on a parameter instead of a declaration. If the attribute
	applies to statements, it should inherit from ``StmtAttr`. If the attribute is			applies to statements, it should inherit from ``StmtAttr``. If the attribute is
	intended to apply to a type instead of a declaration, such an attribute should			intended to apply to a type instead of a declaration, such an attribute should
	derive from ``TypeAttr``, and will generally not be given an AST representation.			derive from ``TypeAttr``, and will generally not be given an AST representation.
	(Note that this document does not cover the creation of type attributes.) An			(Note that this document does not cover the creation of type attributes.) An
	attribute that inherits from ``IgnoredAttr`` is parsed, but will generate an			attribute that inherits from ``IgnoredAttr`` is parsed, but will generate an
	ignored attribute diagnostic when used, which may be useful when an attribute is			ignored attribute diagnostic when used, which may be useful when an attribute is
	supported by another vendor but not supported by clang.			supported by another vendor but not supported by clang.

	The definition will specify several key pieces of information, such as the			The definition will specify several key pieces of information, such as the
	▲ Show 20 Lines • Show All 427 Lines • Show Last 20 Lines