[libcxx] [test] Fix en_US money locale formatting tests on Windows

[mstorsjo]

Summary

In the en_US locale on Windows, negative currency amounts is formatted
as "($0.01)" instead of "-$0.01".

Adjust the test references accordingly, making these tests pass.

This is more of the same as in D120549.

[mstorsjo]

Fix a couple missed differences in the put_money test.

[• Quuxplusone]

Looks reasonable to me. I do still wonder if it would be profitable to introduce a macro throughout instead of repeating the less-greppable #ifdef _WIN32; something like

ASSERT_ON_WIN32(ex == L"   (USD1,234,567.89)");
ASSERT_EXCEPT_WIN32(ex == L"   -USD 1,234,567.89");

or even something like

ASSERT_EQ_WIN32(ex, L"   -USD 1,234,567.89", L"   (USD1,234,567.89)");

(although that's a terrible name and I can't think of a good one).

libcxx/test/std/input.output/iostream.format/ext.manip/get_money.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <iomanip>
 
 // template <class moneyT> T7 get_money(moneyT& mon, bool intl = false);
 
 // REQUIRES: locale.en_US.UTF-8
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <iomanip>
 #include <istream>
 #include <cassert>
 
 #include "test_macros.h"
 #include "platform_support.h" // locale name macros
 
 template <class CharT>
testbuf(const string_type& str)
                    const_cast<CharT*>(str_.data()),
                    const_cast<CharT*>(str_.data()) + str_.size());
     }
 };
 
 int main(int, char**)
 {
     {
+#if defined(_WIN32)
+        testbuf<char> sb("  ($1,234,567.89)");
+#else
         testbuf<char> sb("  -$1,234,567.89");
+#endif
         std::istream is(&sb);
         is.imbue(std::locale(LOCALE_en_US_UTF_8));
         long double x = 0;
         is >> std::get_money(x, false);
         assert(x == -123456789);
     }
     {
+#if defined(_WIN32)
+        testbuf<char> sb("  (USD 1,234,567.89)");
+#else
         testbuf<char> sb("  -USD 1,234,567.89");
+#endif
         std::istream is(&sb);
         is.imbue(std::locale(LOCALE_en_US_UTF_8));
         long double x = 0;
         is >> std::get_money(x, true);
         assert(x == -123456789);
     }
 #ifndef TEST_HAS_NO_WIDE_CHARACTERS
     {
+#if defined(_WIN32)
+        testbuf<wchar_t> sb(L"  ($1,234,567.89)");
+#else
         testbuf<wchar_t> sb(L"  -$1,234,567.89");
+#endif
         std::wistream is(&sb);
         is.imbue(std::locale(LOCALE_en_US_UTF_8));
         long double x = 0;
         is >> std::get_money(x, false);
         assert(x == -123456789);
     }
     {
+#if defined(_WIN32)
+        testbuf<wchar_t> sb(L"  (USD 1,234,567.89)");
+#else
         testbuf<wchar_t> sb(L"  -USD 1,234,567.89");
+#endif
         std::wistream is(&sb);
         is.imbue(std::locale(LOCALE_en_US_UTF_8));
         long double x = 0;
         is >> std::get_money(x, true);
         assert(x == -123456789);
     }
 #endif
 
   return 0;
 }

libcxx/test/std/input.output/iostream.format/ext.manip/put_money.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <iomanip>
 
 // template <class charT, class moneyT> T8 put_money(const moneyT& mon, bool intl = false);
 
 // REQUIRES: locale.en_US.UTF-8
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <iomanip>
 #include <ostream>
 #include <cassert>
 
 #include "test_macros.h"
 #include "platform_support.h" // locale name macros
 
 template <class CharT>

 {
     {
         testbuf<char> sb;
         std::ostream os(&sb);
         os.imbue(std::locale(LOCALE_en_US_UTF_8));
         std::showbase(os);
         long double x = -123456789;
         os << std::put_money(x, false);
+#if defined(_WIN32)
+        assert(sb.str() == "($1,234,567.89)");
+#else
         assert(sb.str() == "-$1,234,567.89");
+#endif
     }
     {
         testbuf<char> sb;
         std::ostream os(&sb);
         os.imbue(std::locale(LOCALE_en_US_UTF_8));
         std::showbase(os);
         long double x = -123456789;
         os << std::put_money(x, true);
+#if defined(_WIN32)
+        assert(sb.str() == "(USD1,234,567.89)");
+#else
         assert(sb.str() == "-USD 1,234,567.89");
+#endif
     }
 #ifndef TEST_HAS_NO_WIDE_CHARACTERS
     {
         testbuf<wchar_t> sb;
         std::wostream os(&sb);
         os.imbue(std::locale(LOCALE_en_US_UTF_8));
         std::showbase(os);
         long double x = -123456789;
         os << std::put_money(x, false);
+#if defined(_WIN32)
+        assert(sb.str() == L"($1,234,567.89)");
+#else
         assert(sb.str() == L"-$1,234,567.89");
+#endif
     }
     {
         testbuf<wchar_t> sb;
         std::wostream os(&sb);
         os.imbue(std::locale(LOCALE_en_US_UTF_8));
         std::showbase(os);
         long double x = -123456789;
         os << std::put_money(x, true);
+#if defined(_WIN32)
+        assert(sb.str() == L"(USD1,234,567.89)");
+#else
         assert(sb.str() == L"-USD 1,234,567.89");
+#endif
     }
 #endif
 
   return 0;
 }

libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_long_double_en_US.pass.cpp

 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 // <locale>
 
 // class money_put<charT, OutputIterator>
 
 // iter_type put(iter_type s, bool intl, ios_base& f, char_type fill,
 //               long double units) const;
 
 // REQUIRES: locale.en_US.UTF-8
-// XFAIL: LIBCXX-WINDOWS-FIXME
 
 #include <locale>
 #include <ios>
 #include <streambuf>
 #include <cassert>
 #include "test_macros.h"
 #include "test_iterators.h"
 
// char, national
         std::string ex(str, iter.base());
         assert(ex == "0.00");
     }
     {   // negative one
         long double v = -1;
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "(0.01)");
+#else
         assert(ex == "-0.01");
+#endif
     }
     {   // positive
         long double v = 123456789;
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "1,234,567.89");
     }
     {   // negative
         long double v = -123456789;
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "(1,234,567.89)");
+#else
         assert(ex == "-1,234,567.89");
+#endif
     }
     {   // zero, showbase
         long double v = 0;
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "$0.00");
     }
     {   // negative one, showbase
         long double v = -1;
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "($0.01)");
+#else
         assert(ex == "-$0.01");
+#endif
     }
     {   // positive, showbase
         long double v = 123456789;
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "$1,234,567.89");
     }
     {   // negative, showbase
         long double v = -123456789;
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "($1,234,567.89)");
+#else
         assert(ex == "-$1,234,567.89");
+#endif
     }
     {   // negative, showbase, left
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::left(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, ' ', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "($1,234,567.89)     ");
+#else
         assert(ex == "-$1,234,567.89      ");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, internal
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::internal(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, ' ', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "($     1,234,567.89)");
+#else
         assert(ex == "-$      1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, right
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::right(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, ' ', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "     ($1,234,567.89)");
+#else
         assert(ex == "      -$1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
 
     // char, international
     std::noshowbase(ios);
     ios.unsetf(std::ios_base::adjustfield);
     {   // zero
         long double v = 0;
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "0.00");
     }
     {   // negative one
         long double v = -1;
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "(0.01)");
+#else
         assert(ex == "-0.01");
+#endif
     }
     {   // positive
         long double v = 123456789;
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "1,234,567.89");
     }
     {   // negative
         long double v = -123456789;
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "(1,234,567.89)");
+#else
         assert(ex == "-1,234,567.89");
+#endif
     }
     {   // zero, showbase
         long double v = 0;
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
-        assert(ex == "USD 0.00");
+#if defined(_WIN32)
+        assert(ex == "USD0.00");
+#else
+        assert(ex == "USD 0.00");
+#endif
     }
     {   // negative one, showbase
         long double v = -1;
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "(USD0.01)");
+#else
         assert(ex == "-USD 0.01");
+#endif
     }
     {   // positive, showbase
         long double v = 123456789;
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
-        assert(ex == "USD 1,234,567.89");
+#if defined(_WIN32)
+        assert(ex == "USD1,234,567.89");
+#else
+        assert(ex == "USD 1,234,567.89");
+#endif
     }
     {   // negative, showbase
         long double v = -123456789;
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "(USD1,234,567.89)");
+#else
         assert(ex == "-USD 1,234,567.89");
+#endif
     }
     {   // negative, showbase, left
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::left(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, ' ', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "(USD1,234,567.89)   ");
+#else
         assert(ex == "-USD 1,234,567.89   ");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, internal
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::internal(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, ' ', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "(USD   1,234,567.89)");
+#else
         assert(ex == "-USD    1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, right
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::right(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, ' ', v);
         std::string ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == "   (USD1,234,567.89)");
+#else
         assert(ex == "   -USD 1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
 }
 #ifndef TEST_HAS_NO_WIDE_CHARACTERS
 {
     const my_facetw f(1);
     // wchar_t, national
     std::noshowbase(ios);
     ios.unsetf(std::ios_base::adjustfield);
     {   // zero
         long double v = 0;
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"0.00");
     }
     {   // negative one
         long double v = -1;
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"(0.01)");
+#else
         assert(ex == L"-0.01");
+#endif
     }
     {   // positive
         long double v = 123456789;
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"1,234,567.89");
     }
     {   // negative
         long double v = -123456789;
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"(1,234,567.89)");
+#else
         assert(ex == L"-1,234,567.89");
+#endif
     }
     {   // zero, showbase
         long double v = 0;
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"$0.00");
     }
     {   // negative one, showbase
         long double v = -1;
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"($0.01)");
+#else
         assert(ex == L"-$0.01");
+#endif
     }
     {   // positive, showbase
         long double v = 123456789;
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"$1,234,567.89");
     }
     {   // negative, showbase
         long double v = -123456789;
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"($1,234,567.89)");
+#else
         assert(ex == L"-$1,234,567.89");
+#endif
     }
     {   // negative, showbase, left
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::left(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"($1,234,567.89)     ");
+#else
         assert(ex == L"-$1,234,567.89      ");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, internal
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::internal(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"($     1,234,567.89)");
+#else
         assert(ex == L"-$      1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, right
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::right(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"     ($1,234,567.89)");
+#else
         assert(ex == L"      -$1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
 
     // wchar_t, international
     std::noshowbase(ios);
     ios.unsetf(std::ios_base::adjustfield);
     {   // zero
         long double v = 0;
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"0.00");
     }
     {   // negative one
         long double v = -1;
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"(0.01)");
+#else
         assert(ex == L"-0.01");
+#endif
     }
     {   // positive
         long double v = 123456789;
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"1,234,567.89");
     }
     {   // negative
         long double v = -123456789;
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"(1,234,567.89)");
+#else
         assert(ex == L"-1,234,567.89");
+#endif
     }
     {   // zero, showbase
         long double v = 0;
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
-        assert(ex == L"USD 0.00");
+#if defined(_WIN32)
+        assert(ex == L"USD0.00");
+#else
+        assert(ex == L"USD 0.00");
+#endif
     }
     {   // negative one, showbase
         long double v = -1;
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"(USD0.01)");
+#else
         assert(ex == L"-USD 0.01");
+#endif
     }
     {   // positive, showbase
         long double v = 123456789;
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
-        assert(ex == L"USD 1,234,567.89");
+#if defined(_WIN32)
+        assert(ex == L"USD1,234,567.89");
+#else
+        assert(ex == L"USD 1,234,567.89");
+#endif
     }
     {   // negative, showbase
         long double v = -123456789;
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"(USD1,234,567.89)");
+#else
         assert(ex == L"-USD 1,234,567.89");
+#endif
     }
     {   // negative, showbase, left
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::left(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"(USD1,234,567.89)   ");
+#else
         assert(ex == L"-USD 1,234,567.89   ");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, internal
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::internal(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"(USD   1,234,567.89)");
+#else
         assert(ex == L"-USD    1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, right
         long double v = -123456789;
         std::showbase(ios);
         ios.width(20);
         std::right(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#if defined(_WIN32)
+        assert(ex == L"   (USD1,234,567.89)");
+#else
         assert(ex == L"   -USD 1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
 }
 #endif // TEST_HAS_NO_WIDE_CHARACTERS
 
   return 0;
 }

libcxx/test/std/localization/locale.categories/category.monetary/locale.money.put/locale.money.put.members/put_string_en_US.pass.cpp

 
 // class money_put<charT, OutputIterator>
 
 // iter_type put(iter_type s, bool intl, ios_base& f, char_type fill,
 //               const string_type& units) const;
 
 // REQUIRES: locale.en_US.UTF-8
 
-// XFAIL: LIBCXX-WINDOWS-FIXME
-
 #include <locale>
 #include <ios>
 #include <streambuf>
 #include <cassert>
 #include "test_macros.h"
 #include "test_iterators.h"
 
 #include "platform_support.h" // locale name macros
// char, national
         std::string ex(str, iter.base());
         assert(ex == "0.00");
     }
     {   // negative one
         std::string v = "-1";
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "(0.01)");
+#else
         assert(ex == "-0.01");
+#endif
     }
     {   // positive
         std::string v = "123456789";
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "1,234,567.89");
     }
     {   // negative
         std::string v = "-123456789";
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "(1,234,567.89)");
+#else
         assert(ex == "-1,234,567.89");
+#endif
     }
     {   // zero, showbase
         std::string v = "0";
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "$0.00");
     }
     {   // negative one, showbase
         std::string v = "-1";
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "($0.01)");
+#else
         assert(ex == "-$0.01");
+#endif
     }
     {   // positive, showbase
         std::string v = "123456789";
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "$1,234,567.89");
     }
     {   // negative, showbase
         std::string v = "-123456789";
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, '*', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "($1,234,567.89)");
+#else
         assert(ex == "-$1,234,567.89");
+#endif
     }
     {   // negative, showbase, left
         std::string v = "-123456789";
         std::showbase(ios);
         ios.width(20);
         std::left(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, ' ', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "($1,234,567.89)     ");
+#else
         assert(ex == "-$1,234,567.89      ");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, internal
         std::string v = "-123456789";
         std::showbase(ios);
         ios.width(20);
         std::internal(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, ' ', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "($     1,234,567.89)");
+#else
         assert(ex == "-$      1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, right
         std::string v = "-123456789";
         std::showbase(ios);
         ios.width(20);
         std::right(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), false, ios, ' ', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "     ($1,234,567.89)");
+#else
         assert(ex == "      -$1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
 
     // char, international
     std::noshowbase(ios);
     ios.unsetf(std::ios_base::adjustfield);
     {   // zero
         std::string v = "0";
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "0.00");
     }
     {   // negative one
         std::string v = "-1";
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "(0.01)");
+#else
         assert(ex == "-0.01");
+#endif
     }
     {   // positive
         std::string v = "123456789";
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
         assert(ex == "1,234,567.89");
     }
     {   // negative
         std::string v = "-123456789";
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "(1,234,567.89)");
+#else
         assert(ex == "-1,234,567.89");
+#endif
     }
     {   // zero, showbase
         std::string v = "0";
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
-        assert(ex == "USD 0.00");
+#ifdef _WIN32
+        assert(ex == "USD0.00");
+#else
+        assert(ex == "USD 0.00");
+#endif
     }
     {   // negative one, showbase
         std::string v = "-1";
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "(USD0.01)");
+#else
         assert(ex == "-USD 0.01");
+#endif
     }
     {   // positive, showbase
         std::string v = "123456789";
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
-        assert(ex == "USD 1,234,567.89");
+#ifdef _WIN32
+        assert(ex == "USD1,234,567.89");
+#else
+        assert(ex == "USD 1,234,567.89");
+#endif
     }
     {   // negative, showbase
         std::string v = "-123456789";
         std::showbase(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, '*', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "(USD1,234,567.89)");
+#else
         assert(ex == "-USD 1,234,567.89");
+#endif
     }
     {   // negative, showbase, left
         std::string v = "-123456789";
         std::showbase(ios);
         ios.width(20);
         std::left(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, ' ', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "(USD1,234,567.89)   ");
+#else
         assert(ex == "-USD 1,234,567.89   ");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, internal
         std::string v = "-123456789";
         std::showbase(ios);
         ios.width(20);
         std::internal(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, ' ', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "(USD   1,234,567.89)");
+#else
         assert(ex == "-USD    1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, right
         std::string v = "-123456789";
         std::showbase(ios);
         ios.width(20);
         std::right(ios);
         char str[100];
         cpp17_output_iterator<char*> iter = f.put(cpp17_output_iterator<char*>(str), true, ios, ' ', v);
         std::string ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == "   (USD1,234,567.89)");
+#else
         assert(ex == "   -USD 1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
 }
 #ifndef TEST_HAS_NO_WIDE_CHARACTERS
 {
     const my_facetw f(1);
     // wchar_t, national
     std::noshowbase(ios);
     ios.unsetf(std::ios_base::adjustfield);
     {   // zero
         std::wstring v = L"0";
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"0.00");
     }
     {   // negative one
         std::wstring v = L"-1";
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"(0.01)");
+#else
         assert(ex == L"-0.01");
+#endif
     }
     {   // positive
         std::wstring v = L"123456789";
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"1,234,567.89");
     }
     {   // negative
         std::wstring v = L"-123456789";
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"(1,234,567.89)");
+#else
         assert(ex == L"-1,234,567.89");
+#endif
     }
     {   // zero, showbase
         std::wstring v = L"0";
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"$0.00");
     }
     {   // negative one, showbase
         std::wstring v = L"-1";
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"($0.01)");
+#else
         assert(ex == L"-$0.01");
+#endif
     }
     {   // positive, showbase
         std::wstring v = L"123456789";
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"$1,234,567.89");
     }
     {   // negative, showbase
         std::wstring v = L"-123456789";
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, '*', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"($1,234,567.89)");
+#else
         assert(ex == L"-$1,234,567.89");
+#endif
     }
     {   // negative, showbase, left
         std::wstring v = L"-123456789";
         std::showbase(ios);
         ios.width(20);
         std::left(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"($1,234,567.89)     ");
+#else
         assert(ex == L"-$1,234,567.89      ");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, internal
         std::wstring v = L"-123456789";
         std::showbase(ios);
         ios.width(20);
         std::internal(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"($     1,234,567.89)");
+#else
         assert(ex == L"-$      1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, right
         std::wstring v = L"-123456789";
         std::showbase(ios);
         ios.width(20);
         std::right(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), false, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"     ($1,234,567.89)");
+#else
         assert(ex == L"      -$1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
 
     // wchar_t, international
     std::noshowbase(ios);
     ios.unsetf(std::ios_base::adjustfield);
     {   // zero
         std::wstring v = L"0";
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"0.00");
     }
     {   // negative one
         std::wstring v = L"-1";
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"(0.01)");
+#else
         assert(ex == L"-0.01");
+#endif
     }
     {   // positive
         std::wstring v = L"123456789";
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
         assert(ex == L"1,234,567.89");
     }
     {   // negative
         std::wstring v = L"-123456789";
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"(1,234,567.89)");
+#else
         assert(ex == L"-1,234,567.89");
+#endif
     }
     {   // zero, showbase
         std::wstring v = L"0";
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
-        assert(ex == L"USD 0.00");
+#ifdef _WIN32
+        assert(ex == L"USD0.00");
+#else
+        assert(ex == L"USD 0.00");
+#endif
     }
     {   // negative one, showbase
         std::wstring v = L"-1";
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"(USD0.01)");
+#else
         assert(ex == L"-USD 0.01");
+#endif
     }
     {   // positive, showbase
         std::wstring v = L"123456789";
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
-        assert(ex == L"USD 1,234,567.89");
+#ifdef _WIN32
+        assert(ex == L"USD1,234,567.89");
+#else
+        assert(ex == L"USD 1,234,567.89");
+#endif
     }
     {   // negative, showbase
         std::wstring v = L"-123456789";
         std::showbase(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, '*', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"(USD1,234,567.89)");
+#else
         assert(ex == L"-USD 1,234,567.89");
+#endif
     }
     {   // negative, showbase, left
         std::wstring v = L"-123456789";
         std::showbase(ios);
         ios.width(20);
         std::left(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"(USD1,234,567.89)   ");
+#else
         assert(ex == L"-USD 1,234,567.89   ");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, internal
         std::wstring v = L"-123456789";
         std::showbase(ios);
         ios.width(20);
         std::internal(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"(USD   1,234,567.89)");
+#else
         assert(ex == L"-USD    1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
     {   // negative, showbase, right
         std::wstring v = L"-123456789";
         std::showbase(ios);
         ios.width(20);
         std::right(ios);
         wchar_t str[100];
         cpp17_output_iterator<wchar_t*> iter = f.put(cpp17_output_iterator<wchar_t*>(str), true, ios, ' ', v);
         std::wstring ex(str, iter.base());
+#ifdef _WIN32
+        assert(ex == L"   (USD1,234,567.89)");
+#else
         assert(ex == L"   -USD 1,234,567.89");
+#endif
         assert(ios.width() == 0);
     }
 }
 #endif // TEST_HAS_NO_WIDE_CHARACTERS
 
   return 0;
 }