Details
- Reviewers
eugenis - Commits
- rG7fbc1f7ebe3b: [MSAN] extend ioctl interceptor to support BLKSSZGET
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
compiler-rt/lib/msan/tests/msan_test.cpp | ||
---|---|---|
714 | Is there a device I can easily use to make this function work correctly? |
compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc | ||
---|---|---|
598 | Please add it to the list instead (the same as done for the other BLK* ioctls). |
compiler-rt/lib/msan/tests/msan_test.cpp | ||
---|---|---|
714 | I'd say it's ok not to test it if it is hard to set up. Especially if you don't add any extra code, only a list entry. |
compiler-rt/lib/msan/tests/msan_test.cpp | ||
---|---|---|
714 | Dropping test. |
compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc | ||
---|---|---|
124 | some of these are wrong: *SET read from the argument, *GET write to the argument. Also, some types are wrong, including in the existing code! BLKRAGET / BLKFRAGET uses uptr, Please double check against the kernel source. | |
129 | uptr instead of SIZE_TYPE |
adjusted types and READ/WRITE
compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc | ||
---|---|---|
124 | Oh. That is embarrassing. Thank you. I used this for the Linux code: https://elixir.bootlin.com/linux/latest/source/block/ioctl.c#L500 |
compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors_ioctl.inc | ||
---|---|---|
124 | No problem! Some of these are still wrong though. |
Is there a device I can easily use to make this function work correctly?