This is an archive of the discontinued LLVM Phabricator instance.

[demangler] Simplify SwapAndRestore
ClosedPublic

Authored by urnathan on Feb 28 2022, 12:18 PM.

Details

Reviewers
iains
ChuanqiXu
Group Reviewers
Restricted Project
Commits
rGe5c98e22fbbe: [demangler] Simplify SwapAndRestore
Summary

The SwapAndRestore class is over engineered. Nothing makes use of the early restoration machinery. Let's just remove that cognitive burden.

Diff Detail

Event Timeline

urnathan requested review of this revision.Feb 28 2022, 12:18 PM
urnathan created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2022, 12:18 PM
ChuanqiXu accepted this revision.Feb 28 2022, 5:36 PM

If restoreNow never gets called, the revision should be good.

This revision is now accepted and ready to land.Feb 28 2022, 5:36 PM
urnathan updated this revision to Diff 412036.Mar 1 2022, 3:46 AM

Fix formating

This revision was landed with ongoing or failed builds.Mar 1 2022, 4:37 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2022, 4:37 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript