This is an archive of the discontinued LLVM Phabricator instance.

Differential D120541

[sanitizer] Disable pc guard coverage test on PPC64/s390x
ClosedPublic

Authored by XiaodongLoong on Feb 24 2022, 10:53 PM.

Details

Reviewers
benshi001
SixWeining
uweigand
Group Reviewers
Restricted Project
Commits
rGa5ee4335c7e7: [sanitizer] Disable pc guard coverage test on PPC64/s390x
Summary

The issue is difficult to fix in a short time, so disable it temporarily.
Github issue: https://github.com/llvm/llvm-project/issues/54071

Diff Detail

Event Timeline

XiaodongLoong created this revision.Feb 24 2022, 10:53 PM
Herald added a subscriber: shchenz. · View Herald TranscriptFeb 24 2022, 10:53 PM
XiaodongLoong requested review of this revision.Feb 24 2022, 10:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2022, 10:53 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
XiaodongLoong added reviewers: benshi001, SixWeining.Feb 24 2022, 11:01 PM
Harbormaster completed remote builds in B151419: Diff 411324.Feb 24 2022, 11:11 PM
MaskRay added a reviewer: Restricted Project.Feb 24 2022, 11:13 PM
MaskRay added a subscriber: MaskRay.

UNSUPPORTED is more appropriate if it may succeed and may fail.

XiaodongLoong added a comment.Feb 24 2022, 11:55 PM

OK, UNSUPPORTED is better.

XiaodongLoong updated this revision to Diff 411332.Feb 24 2022, 11:57 PM

use UNSUPPORTED tag

Harbormaster completed remote builds in B151424: Diff 411332.Feb 25 2022, 12:14 AM
XiaodongLoong updated this revision to Diff 411355.Feb 25 2022, 2:07 AM

disable the test on s390x

XiaodongLoong updated this revision to Diff 411358.Feb 25 2022, 2:13 AM

modify commit message

XiaodongLoong retitled this revision from [sanitizer] Disable pc guard coverage test on PPC64 to [sanitizer] Disable pc guard coverage test on PPC64/s390x.Feb 25 2022, 2:13 AM
Harbormaster completed remote builds in B151443: Diff 411358.Feb 25 2022, 2:31 AM
benshi001 accepted this revision.Feb 25 2022, 4:33 AM
This revision is now accepted and ready to land.Feb 25 2022, 4:33 AM
benshi001 mentioned this in D120472: [sanitizer_common] Enable trace pc guard coverage test on PPC64/s390x/MIPS.Feb 25 2022, 4:50 AM
uweigand accepted this revision.Feb 25 2022, 4:56 AM
uweigand added a subscriber: uweigand.

LGTM, thanks!

This revision was landed with ongoing or failed builds.Feb 25 2022, 5:09 AM
Closed by commit rGa5ee4335c7e7: [sanitizer] Disable pc guard coverage test on PPC64/s390x (authored by XiaodongLoong, committed by benshi001). · Explain Why
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rGa5ee4335c7e7: [sanitizer] Disable pc guard coverage test on PPC64/s390x.

Revision Contents

PathSize
compiler-rt/
test/
sanitizer_common/
TestCases/
2 lines
2 lines

Diff 411382

compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard-dso.cpp

// Tests trace pc guard coverage collection. // Tests trace pc guard coverage collection.
// REQUIRES: has_sancovcc // REQUIRES: has_sancovcc
// UNSUPPORTED: ubsan // UNSUPPORTED: ubsan,powerpc64,s390x
// XFAIL: tsan,darwin // XFAIL: tsan,darwin
// XFAIL: android && asan // XFAIL: android && asan
// RUN: DIR=%t_workdir // RUN: DIR=%t_workdir
// RUN: CLANG_ARGS="-O0 -fsanitize-coverage=trace-pc-guard" // RUN: CLANG_ARGS="-O0 -fsanitize-coverage=trace-pc-guard"
// RUN: rm -rf $DIR // RUN: rm -rf $DIR
// RUN: mkdir -p $DIR // RUN: mkdir -p $DIR
// RUN: cd $DIR // RUN: cd $DIR
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines

compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_trace_pc_guard.cpp

// Tests trace pc guard coverage collection. // Tests trace pc guard coverage collection.
// REQUIRES: has_sancovcc // REQUIRES: has_sancovcc
// UNSUPPORTED: ubsan,i386-darwin // UNSUPPORTED: ubsan,i386-darwin,powerpc64,s390x
// XFAIL: tsan // XFAIL: tsan
// XFAIL: android && asan // XFAIL: android && asan
// RUN: DIR=%t_workdir // RUN: DIR=%t_workdir
// RUN: rm -rf $DIR // RUN: rm -rf $DIR
// RUN: mkdir -p $DIR // RUN: mkdir -p $DIR
// RUN: cd $DIR // RUN: cd $DIR
// RUN: %clangxx -O0 -fsanitize-coverage=trace-pc-guard %s -o %t // RUN: %clangxx -O0 -fsanitize-coverage=trace-pc-guard %s -o %t
Show All 29 Lines