[clang-format] Treat && followed by noexcept operator as a binary operator inside template arguments

[penagos]

Summary

Fixes https://github.com/llvm/llvm-project/issues/44544.

[curdeius]

LGTM, but please rebase so that CI runs.

[penagos]

Rebase to trigger CI.

[penagos]

I went ahead and did a git rebase but CI still appears to be failing (though tests pass in my local clone). Also, I’ll need someone to commit this on my behalf:

• Luis Penagos
• [e-mail]

Thanks!

[curdeius]

In D120445#3344594, @penagos wrote:

I went ahead and did a git rebase but CI still appears to be failing (though tests pass in my local clone). Also, I’ll need someone to commit this on my behalf:

• Luis Penagos
• [e-mail]

Thanks!

Thank you, the failures are unrelated, these tests (libarcher, libomp...) failed in other precommit CI builds.
I'll commit it this weekend probably but I let other reviewers have a look.

clang/lib/Format/TokenAnnotator.cpp

TokenType determineStarAmpUsage(const FormatToken &Tok, bool IsExpression,
     if (Style.isCSharp() && Tok.is(tok::ampamp))
       return TT_BinaryOperator;
 
     const FormatToken *PrevToken = Tok.getPreviousNonComment();
     if (!PrevToken)
       return TT_UnaryOperator;
 
     const FormatToken *NextToken = Tok.getNextNonComment();
+
+    if (InTemplateArgument && NextToken && NextToken->is(tok::kw_noexcept))
+      return TT_BinaryOperator;
+
     if (!NextToken ||
         NextToken->isOneOf(tok::arrow, tok::equal, tok::kw_noexcept) ||
         NextToken->canBePointerOrReferenceQualifier() ||
         (NextToken->is(tok::l_brace) && !NextToken->getNextNonComment()))
       return TT_PointerOrReference;
 
     if (PrevToken->is(tok::coloncolon))
       return TT_PointerOrReference;

clang/unittests/Format/FormatTest.cpp

TEST_F(FormatTest, UnderstandsTemplateParameters) {
   verifyFormat("struct A<std::enable_if<sizeof(T2) < sizeof(int32)>::type>;");
   verifyFormat("struct A<std::enable_if<sizeof(T2) ? sizeof(int32) : "
                "sizeof(char)>::type>;");
   verifyFormat("template <class T> struct S<std::is_arithmetic<T>{}> {};");
   verifyFormat("f(a.operator()<A>());");
   verifyFormat("f(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
                "      .template operator()<A>());",
                getLLVMStyleWithColumns(35));
+  verifyFormat("bool_constant<a && noexcept(f())>");
+  verifyFormat("bool_constant<a || noexcept(f())>");
 
   // Not template parameters.
   verifyFormat("return a < b && c > d;");
   verifyFormat("void f() {\n"
                "  while (a < b && c > d) {\n"
                "  }\n"
                "}");
   verifyFormat("template <typename... Types>\n"