This is an archive of the discontinued LLVM Phabricator instance.

Differential D120349

[NFC][PowerPC] Fix the check-cpu.ll test case.
ClosedPublic

Authored by stefanp on Feb 22 2022, 12:54 PM.

Details

Reviewers
lei
nemanjai
Group Reviewers
Restricted Project
Commits
rGb3e63ee2e5bd: [NFC][PowerPC] Fix the check-cpu.ll test case.
Summary

This test doesn't work because the CHECK-NOT line is actually checking
something that only exists on stderr and not stdout.
Changed the test so that we now check both stderr and stdout.
Changed the test so that we check pwr9, pwr10, and future. The cpu names of
power9 or power10 are not supported in the llc backend.

Diff Detail

Event Timeline

stefanp created this revision.Feb 22 2022, 12:54 PM
Herald added a subscriber: shchenz. · View Herald TranscriptFeb 22 2022, 12:54 PM
stefanp requested review of this revision.Feb 22 2022, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2022, 12:54 PM
stefanp added a reviewer: Restricted Project.Feb 22 2022, 12:54 PM
Harbormaster completed remote builds in B150918: Diff 410615.Feb 22 2022, 1:33 PM
nemanjai accepted this revision.Feb 23 2022, 2:06 AM

LGTM.

This revision is now accepted and ready to land.Feb 23 2022, 2:06 AM
This revision was landed with ongoing or failed builds.Feb 23 2022, 12:09 PM
Closed by commit rGb3e63ee2e5bd: [NFC][PowerPC] Fix the check-cpu.ll test case. (authored by stefanp). · Explain Why
This revision was automatically updated to reflect the committed changes.
stefanp added a commit: rGb3e63ee2e5bd: [NFC][PowerPC] Fix the check-cpu.ll test case..

Revision Contents

PathSize
llvm/
test/
CodeGen/
PowerPC/
15 lines

Diff 410905

llvm/test/CodeGen/PowerPC/check-cpu.ll

; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \ ; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
; RUN: -mcpu=future < %s | FileCheck %s ; RUN: -mcpu=future < %s 2>&1 | FileCheck %s
; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu \ ; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu \
; RUN: -mcpu=future < %s | FileCheck %s ; RUN: -mcpu=future < %s 2>&1 | FileCheck %s
; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \ ; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
; RUN: -mcpu=power10 < %s | FileCheck %s ; RUN: -mcpu=pwr10 < %s 2>&1 | FileCheck %s
; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu \ ; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu \
; RUN: -mcpu=pwr10 < %s | FileCheck %s ; RUN: -mcpu=pwr10 < %s 2>&1 | FileCheck %s
; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \
; RUN: -mcpu=pwr9 < %s 2>&1 | FileCheck %s
; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu \
; RUN: -mcpu=pwr9 < %s 2>&1 | FileCheck %s
; Test -mcpu=[pwr10|future] is recognized on PowerPC. ; Test -mcpu=[pwr9|pwr10|future] is recognized on PowerPC.
; CHECK-NOT: is not a recognized processor for this target ; CHECK-NOT: is not a recognized processor for this target
; CHECK: .text ; CHECK: .text