This is an archive of the discontinued LLVM Phabricator instance.

Differential D120276

[move-function] Make test more generally by removing unneeded line.
ClosedPublic

Authored by gottesmm on Feb 21 2022, 12:10 PM.

Details

Reviewers
fhahn
Commits
rG13681ad6540f: [move-function] Make test more generally by removing unneeded line.
Summary

Otherwise this is can be sensitive in the face of changes in register names.

I also gardened the test case a little to make it look a little nicer.

Diff Detail

Unit TestsFailed

TimeTest
60,080 msx64 debian > AddressSanitizer-x86_64-linux-dynamic.TestCases::scariness_score_test.cpp
60,120 msx64 debian > AddressSanitizer-x86_64-linux.TestCases::scariness_score_test.cpp
60,150 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg.c
60,250 msx64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vluxseg.c
70 msx64 debian > LLVM.Transforms/ArgumentPromotion::crash.ll
View Full Test Results (6 Failed)

Event Timeline

gottesmm created this revision.Feb 21 2022, 12:10 PM
gottesmm added inline comments.Feb 21 2022, 12:11 PM
llvm/test/Transforms/Coroutines/coro-debug-dbg.addr-swift.ll
22

This is the substance of the change. Using %.debug here and CHECK-NEXT is too sensitive to small changes in the rest of the codebase. It isn't needed here.

fhahn published this revision for review.Feb 21 2022, 12:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2022, 12:14 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B150743: Diff 410363.Feb 21 2022, 1:13 PM
gottesmm added a comment.Feb 21 2022, 1:52 PM

Looked at the failures. The windows one got into LLVM and this test passed. The test that failed was:

LLVM :: Transforms/ArgumentPromotion/crash.ll

This commit just tweaks this specific test, so it shouldn't have caused that.

The Debian one failed also in other llvm tests. This test ran successfully.

gottesmm added a reviewer: fhahn.Feb 21 2022, 1:52 PM
fhahn accepted this revision.Feb 21 2022, 2:12 PM

LGTM, thanks! I guess we could use a pattern instead of the hardcoded %.debug name, but IIUC the important part is to make sure the test contains the relevant dbg. calls, so this makes it more robust in any case!

This revision is now accepted and ready to land.Feb 21 2022, 2:12 PM
This revision was landed with ongoing or failed builds.Feb 21 2022, 2:40 PM
Closed by commit rG13681ad6540f: [move-function] Make test more generally by removing unneeded line. (authored by gottesmm). · Explain Why
This revision was automatically updated to reflect the committed changes.
gottesmm added a commit: rG13681ad6540f: [move-function] Make test more generally by removing unneeded line..

Revision Contents

PathSize
llvm/
test/
Transforms/
Coroutines/
13 lines

Diff 410363

llvm/test/Transforms/Coroutines/coro-debug-dbg.addr-swift.ll

; Tests whether we properly setup llvm.dbg.addr for Swift. ; Tests whether we properly setup llvm.dbg.addr for Swift.
; ;
; Since we do not have any guarantees around the usage of llvm.dbg.addr, we can ; Since we do not have any guarantees around the usage of llvm.dbg.addr, we can
; not propagate them like we do llvm.dbg.declare into funclets. But if users ; not propagate them like we do llvm.dbg.declare into funclets. But if users
; create the debug_value for us, make sure that we propagate llvm.dbg.addr into ; create the debug_value for us, make sure that we propagate llvm.dbg.addr into
; the beginning coroutine and all other funclets. ; the beginning coroutine and all other funclets.
; RUN: opt %s -passes='function(coro-early),cgscc(coro-split,simplifycfg)' -S | FileCheck %s ; RUN: opt %s -passes='function(coro-early),cgscc(coro-split,simplifycfg)' -S | FileCheck %s
; CHECK-LABEL: define swifttailcc void @"$s10async_args14withGenericArgyyxnYalF"(%swift.context* swiftasync %0, %swift.opaque* noalias %1, %swift.type* %T){{.*}} { ; CHECK-LABEL: define swifttailcc void @"$s10async_args14withGenericArgyyxnYalF"(%swift.context* swiftasync %0, %swift.opaque* noalias %1, %swift.type* %T){{.*}} {
; CHECK: call void @llvm.dbg.declare( ; CHECK: call void @llvm.dbg.declare(
; CHECK: llvm.dbg.addr ; CHECK: call void @llvm.dbg.addr(
; CHECK-NOT: llvm.dbg.value ; CHECK-NOT: llvm.dbg.value
; CHECK-NOT: llvm.dbg.addr ; CHECK-NOT: llvm.dbg.addr
; CHECK-NOT: llvm.dbg.declare ; CHECK-NOT: llvm.dbg.declare
; CHECK: musttail call swifttailcc void @swift_task_switch(%swift.context* swiftasync %19, i8* bitcast (void (i8*)* @"$s10async_args14withGenericArgyyxnYalFTY0_" to i8*), i64 0, i64 0) ; CHECK: musttail call swifttailcc void @swift_task_switch(%swift.context* swiftasync %19, i8* bitcast (void (i8*)* @"$s10async_args14withGenericArgyyxnYalFTY0_" to i8*), i64 0, i64 0)
; CHECK-NEXT: ret void ; CHECK-NEXT: ret void
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK-LABEL: define internal swifttailcc void @"$s10async_args14withGenericArgyyxnYalFTY0_"(i8* swiftasync %0) ; CHECK-LABEL: define internal swifttailcc void @"$s10async_args14withGenericArgyyxnYalFTY0_"(i8* swiftasync %0)
; CHECK: entryresume.0 ; CHECK: entryresume.0
; CHECK-NEXT: %.debug ; CHECK: call void @llvm.dbg.declare(
gottesmmAuthorUnsubmitted
Done
ReplyInline Actions

This is the substance of the change. Using %.debug here and CHECK-NEXT is too sensitive to small changes in the rest of the codebase. It isn't needed here.

gottesmm: This is the substance of the change. Using %.debug here and CHECK-NEXT is too sensitive to…
; CHECK-NEXT: call void @llvm.dbg.declare( ; CHECK: call void @llvm.dbg.addr(
; CHECK: llvm.dbg.addr
; CHECK: musttail call swifttailcc void @"$s10async_args10forceSplityyYaF"(%swift.context* swiftasync ; CHECK: musttail call swifttailcc void @"$s10async_args10forceSplityyYaF"(%swift.context* swiftasync
; CHECK-NEXT: ret void ; CHECK-NEXT: ret void
; CHECK-NEXT: } ; CHECK-NEXT: }
; CHECK: define internal swifttailcc void @"$s10async_args14withGenericArgyyxnYalFTQ1_"(i8* swiftasync %0) ; CHECK: define internal swifttailcc void @"$s10async_args14withGenericArgyyxnYalFTQ1_"(i8* swiftasync %0)
; CHECK: llvm.dbg.declare ; CHECK: call void @llvm.dbg.declare
; CHECK: llvm.dbg.addr ; CHECK: call void @llvm.dbg.addr
; CHECK: llvm.dbg.value(metadata %swift.opaque** undef, ; CHECK: call void @llvm.dbg.value(metadata %swift.opaque** undef,
; CHECK: ret void ; CHECK: ret void
; CHECK-NEXT: } ; CHECK-NEXT: }
; ModuleID = 'async_args.ll' ; ModuleID = 'async_args.ll'
source_filename = "async_args.ll" source_filename = "async_args.ll"
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-apple-macosx11.0.0" target triple = "x86_64-apple-macosx11.0.0"
▲ Show 20 Lines • Show All 402 Lines • Show Last 20 Lines