Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[move-function] Make test more generally by removing unneeded line.
ClosedPublic

Authored by gottesmm on Feb 21 2022, 12:10 PM.

Details

Summary

Otherwise this is can be sensitive in the face of changes in register names.

I also gardened the test case a little to make it look a little nicer.

Diff Detail

Event Timeline

gottesmm created this revision.Feb 21 2022, 12:10 PM
gottesmm added inline comments.Feb 21 2022, 12:11 PM
llvm/test/Transforms/Coroutines/coro-debug-dbg.addr-swift.ll
22

This is the substance of the change. Using %.debug here and CHECK-NEXT is too sensitive to small changes in the rest of the codebase. It isn't needed here.

fhahn published this revision for review.Feb 21 2022, 12:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2022, 12:14 PM

Looked at the failures. The windows one got into LLVM and this test passed. The test that failed was:

LLVM :: Transforms/ArgumentPromotion/crash.ll

This commit just tweaks this specific test, so it shouldn't have caused that.

The Debian one failed also in other llvm tests. This test ran successfully.

fhahn accepted this revision.Feb 21 2022, 2:12 PM

LGTM, thanks! I guess we could use a pattern instead of the hardcoded %.debug name, but IIUC the important part is to make sure the test contains the relevant dbg. calls, so this makes it more robust in any case!

This revision is now accepted and ready to land.Feb 21 2022, 2:12 PM
This revision was landed with ongoing or failed builds.Feb 21 2022, 2:40 PM
This revision was automatically updated to reflect the committed changes.