This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
test/Frontend/
-
Frontend/
-
dependency-gen.c

Differential D12021

Remove test cases, which rely on the default sanitizer blacklists.
ClosedPublic

Authored by krasin on Aug 13 2015, 4:21 PM.

Download Raw Diff

Details

Reviewers

pcc
chapuni

Commits

rG9cc0420211e9: Remove test cases, which rely on the default sanitizer blacklists.
rC244985: Remove test cases, which rely on the default sanitizer blacklists.
rL244985: Remove test cases, which rely on the default sanitizer blacklists.

Summary

The default blacklists may vary across different architectures and
configurations. It was not wise to include into http://reviews.llvm.org/D11968

Diff Detail

Event Timeline

krasin updated this revision to Diff 32107.Aug 13 2015, 4:21 PM

krasin retitled this revision from to Remove test cases, which rely on the default sanitizer blacklists. The default blacklists may vary across different architectures and configurations. It was not wise to include into http://reviews.llvm.org/D11968.

krasin updated this object.

krasin added a reviewer: chapuni.

krasin added subscribers: pcc, cfe-commits.

krasin retitled this revision from Remove test cases, which rely on the default sanitizer blacklists. The default blacklists may vary across different architectures and configurations. It was not wise to include into http://reviews.llvm.org/D11968 to Remove test cases, which rely on the default sanitizer blacklists..Aug 13 2015, 4:22 PM

krasin updated this object.

You could create a fake resource directory which contains only the asan_blacklist.txt file. See test/Driver/Inputs/resource_dir for an example of this kind of thing.

In D12021#224102, @pcc wrote:

You could create a fake resource directory which contains only the asan_blacklist.txt file. See test/Driver/Inputs/resource_dir for an example of this kind of thing.

I believe it's unnecessary. The default blacklists are handled in https://github.com/llvm-mirror/clang/blob/82a8792ad361e9443615fc81ee8dd37c76e64dbd/lib/Driver/SanitizerArgs.cpp#L82, and the code I added is in the frontend. The tests I am removing are not really testing that blacklists get into the deps. They test that default blacklists are explicitly passed from the toolchain to the frontend. If there's no such a test, I could add it in a separate CL, and it will be a driver test, not a frontend test.

LGTM

Yes, this can be a separate driver test.

This revision is now accepted and ready to land.Aug 13 2015, 4:34 PM

krasin closed this revision.Aug 13 2015, 4:38 PM

pcc mentioned this in D12544: Do not include default sanitizer blacklists into -M/-MM/-MD/-MMD output..Sep 1 2015, 4:09 PM

Revision Contents

Path

Size

test/

Frontend/

dependency-gen.c

5 lines

Diff 32107

test/Frontend/dependency-gen.c

	Show All 18 Lines
	// CHECK-FIVE: {{ }}a/b/.{{[/\\]}}x.h			// CHECK-FIVE: {{ }}a/b/.{{[/\\]}}x.h
	// RUN: cd a/b			// RUN: cd a/b
	// RUN: %clang -MD -MF - %s -fsyntax-only -I ./ \| FileCheck -check-prefix=CHECK-SIX %s			// RUN: %clang -MD -MF - %s -fsyntax-only -I ./ \| FileCheck -check-prefix=CHECK-SIX %s
	// CHECK-SIX: {{ }}x.h			// CHECK-SIX: {{ }}x.h
	// RUN: echo "fun:foo" > %t.blacklist			// RUN: echo "fun:foo" > %t.blacklist
	// RUN: %clang -MD -MF - %s -fsyntax-only -fsanitize=cfi-vcall -flto -fsanitize-blacklist=%t.blacklist -I ./ \| FileCheck -check-prefix=CHECK-SEVEN %s			// RUN: %clang -MD -MF - %s -fsyntax-only -fsanitize=cfi-vcall -flto -fsanitize-blacklist=%t.blacklist -I ./ \| FileCheck -check-prefix=CHECK-SEVEN %s
	// CHECK-SEVEN: .blacklist			// CHECK-SEVEN: .blacklist
	// CHECK-SEVEN: {{ }}x.h			// CHECK-SEVEN: {{ }}x.h
	// RUN: %clang -target x86_64-linux-gnu -MD -MF - %s -fsyntax-only -fsanitize=address -flto -I . \| FileCheck -check-prefix=CHECK-EIGHT %s
	// CHECK-EIGHT: {{ }}x.h
	// RUN: %clang -target x86_64-linux-gnu -MD -MF - %s -fsyntax-only -fsanitize=address -flto -I . -fno-sanitize-blacklist \| FileCheck -check-prefix=CHECK-NINE %s
	// CHECK-NINE-NOT: asan_blacklist.txt
	// CHECK-NINE: {{ }}x.h
	#ifndef INCLUDE_FLAG_TEST			#ifndef INCLUDE_FLAG_TEST
	#include <x.h>			#include <x.h>
	#endif			#endif