This is an archive of the discontinued LLVM Phabricator instance.

Differential D120179

[mlir][spirv] Fix SPIR-V spec parser
ClosedPublic

Authored by alexbatashev on Feb 19 2022, 12:58 AM.

Details

Reviewers
antiagainst
Commits
rG01c0b4d51c50: [mlir][spirv] Fix SPIR-V spec parser
Summary

Header class in SPIR-V HTML spec has changed. Update script to reflect that.

Diff Detail

Event Timeline

alexbatashev created this revision.Feb 19 2022, 12:58 AM
Herald added a reviewer: antiagainst. · View Herald TranscriptFeb 19 2022, 12:58 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 20 others. · View Herald Transcript
alexbatashev requested review of this revision.Feb 19 2022, 12:58 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptFeb 19 2022, 12:58 AM
Harbormaster completed remote builds in B150527: Diff 410071.Feb 19 2022, 1:18 AM
antiagainst accepted this revision.Feb 21 2022, 5:58 PM
This revision is now accepted and ready to land.Feb 21 2022, 5:58 PM
Closed by commit rG01c0b4d51c50: [mlir][spirv] Fix SPIR-V spec parser (authored by alexbatashev). · Explain WhyFeb 22 2022, 3:16 AM
This revision was automatically updated to reflect the committed changes.
alexbatashev added a commit: rG01c0b4d51c50: [mlir][spirv] Fix SPIR-V spec parser.

Revision Contents

PathSize
mlir/
utils/
spirv/
2 lines

Diff 410496

mlir/utils/spirv/gen_spirv_dialect.py

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines if settings.gen_ocl_ops:
section_anchor = spirv.find('h2', {'id': '_binary_form'}) section_anchor = spirv.find('h2', {'id': '_binary_form'})
for section in section_anchor.parent.find_all('div', {'class': 'sect2'}): for section in section_anchor.parent.find_all('div', {'class': 'sect2'}):
for table in section.find_all('table'): for table in section.find_all('table'):
inst_html = table.tbody.tr.td inst_html = table.tbody.tr.td
opname = inst_html.a['id'] opname = inst_html.a['id']
# Ignore the first line, which is just the opname. # Ignore the first line, which is just the opname.
doc[opname] = inst_html.text.split('\n', 1)[1].strip() doc[opname] = inst_html.text.split('\n', 1)[1].strip()
else: else:
section_anchor = spirv.find('h3', {'id': '_a_id_instructions_a_instructions'}) section_anchor = spirv.find('h3', {'id': '_instructions_3'})
for section in section_anchor.parent.find_all('div', {'class': 'sect3'}): for section in section_anchor.parent.find_all('div', {'class': 'sect3'}):
for table in section.find_all('table'): for table in section.find_all('table'):
inst_html = table.tbody.tr.td.p inst_html = table.tbody.tr.td.p
opname = inst_html.a['id'] opname = inst_html.a['id']
# Ignore the first line, which is just the opname. # Ignore the first line, which is just the opname.
doc[opname] = inst_html.text.split('\n', 1)[1].strip() doc[opname] = inst_html.text.split('\n', 1)[1].strip()
return doc return doc
▲ Show 20 Lines • Show All 1,010 Lines • Show Last 20 Lines