This is an archive of the discontinued LLVM Phabricator instance.

Differential D120171

[scudo] Add missing <algorithm> include
ClosedPublic

Authored by gulfem on Feb 18 2022, 5:01 PM.

Details

Reviewers
cryptoad
phosek
Commits
rG3d728ef0ba28: [scudo] Add missing <algorithm> include
Summary

After https://reviews.llvm.org/D119667, <algorithm> is no longer
transitively included from various headers. This patch adds the
<algorithm> include into scudo.

Diff Detail

Event Timeline

gulfem created this revision.Feb 18 2022, 5:01 PM
Herald added a subscriber: cryptoad. · View Herald TranscriptFeb 18 2022, 5:01 PM
gulfem requested review of this revision.Feb 18 2022, 5:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2022, 5:01 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
gulfem added reviewers: cryptoad, phosek.Feb 18 2022, 5:03 PM
phosek accepted this revision.Feb 18 2022, 5:05 PM

LGTM

This revision is now accepted and ready to land.Feb 18 2022, 5:05 PM
This revision was landed with ongoing or failed builds.Feb 18 2022, 5:15 PM
Closed by commit rG3d728ef0ba28: [scudo] Add missing <algorithm> include (authored by gulfem). · Explain Why
This revision was automatically updated to reflect the committed changes.
gulfem added a commit: rG3d728ef0ba28: [scudo] Add missing <algorithm> include.
Harbormaster completed remote builds in B150507: Diff 410045.Feb 18 2022, 5:21 PM

Revision Contents

PathSize
compiler-rt/
lib/
scudo/
standalone/
tests/
1 line

Diff 410045

compiler-rt/lib/scudo/standalone/tests/secondary_test.cpp

//===-- secondary_test.cpp --------------------------------------*- C++ -*-===// //===-- secondary_test.cpp --------------------------------------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "memtag.h" #include "memtag.h"
#include "tests/scudo_unit_test.h" #include "tests/scudo_unit_test.h"
#include "allocator_config.h" #include "allocator_config.h"
#include "secondary.h" #include "secondary.h"
#include <algorithm>
#include <condition_variable> #include <condition_variable>
#include <memory> #include <memory>
#include <mutex> #include <mutex>
#include <random> #include <random>
#include <stdio.h> #include <stdio.h>
#include <thread> #include <thread>
#include <vector> #include <vector>
▲ Show 20 Lines • Show All 220 Lines • Show Last 20 Lines