[NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue.

[zahiraam]

Summary

In our downstream, we discovered that the that the .* wildcard
in debug-info-hotpatch.cpp (added https://reviews.llvm.org/D116511)
ended up matching the entire line on our Windows configurations, causing
the -function-padmin check to already be consumed. After digging into it
we weren't able to find any sort of reason why the platform would matter
here, however we suspect there must be some difference in the regex
matcher between systems.
This NFC patch replaces the regex with a more conservative regex that
prevents this from happening by replacing the . match with an 'everything
but double-quote match, [^"].

[erichkeane]

Commit message isn't particularly good either.

Perhaps something like:

[NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue

In our downstream, we discovered that the that the .* wildcard
in debug-info-hotpatch.cpp (added https://reviews.llvm.org/D116511)
ended up matching the entire line on our Windows configurations, causing
the -function-padmin check to already be consumed. After digging into it
we weren't able to find any sort of reason why the platform would matter
here, however we suspect there must be some difference in the regex matcher
between systems.

This NFC patch replaces the regex with a more conservative regex that prevents
this from happening by replacing the . match with an 'everything but double-
quote match, [^"].

clang/test/CodeGenCXX/debug-info-hotpatch.cpp

17

This part of the change shouldn't be necessary, right? I'd probably prefer not to have this part unless needed.

[erichkeane]

Feel free to commit with the suggestions I added above.

[probinson]

Seems to me there have been other cases where .* matching was greedier than expected, so this seems like the right fix.

clang/test/CodeGenCXX/debug-info-hotpatch.cpp

 // REQUIRES: x86-registered-target
 ///
 // RUN: %clang_cl --target=x86_64-windows-msvc /c /hotpatch /Z7 -o %t.obj -- %s
 // RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=HOTPATCH
 // HOTPATCH: S_COMPILE3 [size = [[#]]]
 // HOTPATCH: flags = hot patchable
 ///
 // RUN: %clang_cl --target=x86_64-windows-msvc /c /Z7 -o %t.obj -- %s
 // RUN: llvm-pdbutil dump -symbols %t.obj | FileCheck %s --check-prefix=NO-HOTPATCH
 // NO-HOTPATCH-NOT: flags = hot patchable
 ///
 // RUN: %clang_cl --target=x86_64-windows-msvc /hotpatch -### -- %s 2>&1 \
 // RUN:    | FileCheck %s --check-prefix=FUNCTIONPADMIN
 // FUNCTIONPADMIN: clang{{.*}}
-// FUNCTIONPADMIN: {{link.*"}}
+// FUNCTIONPADMIN: {{link[^"]*"}} 
 // FUNCTIONPADMIN: -functionpadmin
 
 int main() {
   return 0;
 }