This is an archive of the discontinued LLVM Phabricator instance.

Differential D119873

[HWASan] add test for debug info of allocas that don't need padding.
ClosedPublic

Authored by fmayer on Feb 15 2022, 11:42 AM.

Details

Reviewers
eugenis
Commits
rG8f780ba36269: [HWASan] add test for debug info of allocas that don't need padding.

Diff Detail

Event Timeline

fmayer requested review of this revision.Feb 15 2022, 11:42 AM
fmayer created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2022, 11:42 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
fmayer added a reviewer: eugenis.Feb 15 2022, 11:42 AM
Herald added a subscriber: ormris. · View Herald TranscriptFeb 15 2022, 11:42 AM
eugenis added inline comments.Feb 15 2022, 12:30 PM
llvm/test/Instrumentation/HWAddressSanitizer/dbg-value-tag-offset-nopad.ll
15

Could you also test that this points to the right alloca?

Harbormaster completed remote builds in B149780: Diff 408987.Feb 15 2022, 1:54 PM
fmayer updated this revision to Diff 409329.Feb 16 2022, 10:50 AM

address comment

ormris removed a subscriber: ormris.Feb 16 2022, 10:50 AM
fmayer marked an inline comment as done.Feb 16 2022, 10:50 AM
fmayer mentioned this in D119961: [HWASan] Improve dbg-value-tag-offset test..Feb 16 2022, 10:55 AM
Harbormaster completed remote builds in B150017: Diff 409329.Feb 16 2022, 11:43 AM
fmayer added a comment.Feb 22 2022, 11:10 AM

ping

eugenis accepted this revision.Feb 23 2022, 1:20 PM

LGTM

This revision is now accepted and ready to land.Feb 23 2022, 1:20 PM
This revision was landed with ongoing or failed builds.Feb 23 2022, 2:03 PM
Closed by commit rG8f780ba36269: [HWASan] add test for debug info of allocas that don't need padding. (authored by fmayer). · Explain Why
This revision was automatically updated to reflect the committed changes.
fmayer added a commit: rG8f780ba36269: [HWASan] add test for debug info of allocas that don't need padding..

Revision Contents

PathSize
llvm/
test/
Instrumentation/
HWAddressSanitizer/
61 lines

Diff 410936

llvm/test/Instrumentation/HWAddressSanitizer/dbg-value-tag-offset-nopad.ll

  • This file was added.
; RUN: opt -passes=hwasan -S -o - %s | FileCheck %s
target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
target triple = "aarch64-unknown-linux-android24"
define dso_local void @f() sanitize_hwaddress !dbg !14 {
%a1 = alloca i128, align 4
%a2 = alloca i128, align 4
%1 = bitcast i128* %a1 to i8*, !dbg !21
%2 = bitcast i128* %a2 to i8*, !dbg !21
; CHECK: call void @llvm.dbg.value(metadata i128 1, {{.*}}, metadata !DIExpression())
call void @llvm.dbg.value(metadata i128 1, metadata !20, metadata !DIExpression()), !dbg !22
store i128 1, i128* %a2, align 4, !dbg !23, !tbaa !24
; CHECK: call void @llvm.dbg.value(metadata i128* %a1, {{.*}}, metadata !DIExpression(DW_OP_LLVM_tag_offset, 0, DW_OP_deref))
call void @llvm.dbg.value(metadata i128* %a1, metadata !18, metadata !DIExpression(DW_OP_deref)), !dbg !22
eugenisUnsubmitted
Done
ReplyInline Actions

Could you also test that this points to the right alloca?

eugenis: Could you also test that this points to the right alloca?
call void @use(i8* nonnull %1), !dbg !28
; CHECK: call void @llvm.dbg.value(metadata i128* %a2, {{.*}}, metadata !DIExpression(DW_OP_LLVM_tag_offset, 128, DW_OP_deref))
call void @llvm.dbg.value(metadata i128* %a2, metadata !20, metadata !DIExpression(DW_OP_deref)), !dbg !22
call void @use(i8* nonnull %2), !dbg !29
ret void, !dbg !30
}
declare !dbg !5 void @use(i8*)
declare void @llvm.dbg.value(metadata, metadata, metadata)
!llvm.dbg.cu = !{!0}
!llvm.module.flags = !{!8, !9, !10, !11, !12}
!llvm.ident = !{!13}
!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus_14, file: !1, producer: "clang version 10.0.0 (git@github.com:llvm/llvm-project.git 5560dd08b99a0e8b0c55116376624e4f967caec5)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, retainedTypes: !3, nameTableKind: None)
!1 = !DIFile(filename: "dbg.cc", directory: "/tmp")
!2 = !{}
!3 = !{!4, !5}
!4 = !DIDerivedType(tag: DW_TAG_pointer_type, baseType: null, size: 64)
!5 = !DISubprogram(name: "use", scope: !1, file: !1, line: 2, type: !6, flags: DIFlagPrototyped, spFlags: DISPFlagOptimized, retainedNodes: !2)
!6 = !DISubroutineType(types: !7)
!7 = !{null, !4}
!8 = !{i32 7, !"Dwarf Version", i32 4}
!9 = !{i32 2, !"Debug Info Version", i32 3}
!10 = !{i32 1, !"wchar_size", i32 4}
!11 = !{i32 7, !"PIC Level", i32 2}
!12 = !{i32 7, !"PIE Level", i32 2}
!13 = !{!"clang version 10.0.0 (git@github.com:llvm/llvm-project.git 5560dd08b99a0e8b0c55116376624e4f967caec5)"}
!14 = distinct !DISubprogram(name: "f", scope: !1, file: !1, line: 4, type: !15, scopeLine: 4, flags: DIFlagPrototyped | DIFlagAllCallsDescribed, spFlags: DISPFlagDefinition | DISPFlagOptimized, unit: !0, retainedNodes: !17)
!15 = !DISubroutineType(types: !16)
!16 = !{null}
!17 = !{!18, !20}
!18 = !DILocalVariable(name: "x", scope: !14, file: !1, line: 5, type: !19)
!19 = !DIBasicType(name: "int", size: 32, encoding: DW_ATE_signed)
!20 = !DILocalVariable(name: "y", scope: !14, file: !1, line: 5, type: !19)
!21 = !DILocation(line: 5, column: 3, scope: !14)
!22 = !DILocation(line: 0, scope: !14)
!23 = !DILocation(line: 5, column: 10, scope: !14)
!24 = !{!25, !25, i64 0}
!25 = !{!"int", !26, i64 0}
!26 = !{!"omnipotent char", !27, i64 0}
!27 = !{!"Simple C++ TBAA"}
!28 = !DILocation(line: 6, column: 3, scope: !14)
!29 = !DILocation(line: 7, column: 3, scope: !14)
!30 = !DILocation(line: 8, column: 1, scope: !14)