This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Make the put_long_double test pass on mingw, clarify quirks in put_double
ClosedPublic

Authored by mstorsjo on Feb 14 2022, 12:33 PM.

Details

Summary

Expect the same NAN formatting on Windows as on Glibc. (Both MSVC and
MinGW produce the same formatting there.)

The hex float formatting tests pass on MinGW, so opt in to those tests.

Document exactly what issues are remaining in Clang-cl/MSVC
configurations. (It's easily possible to make the tests pass there too,
but it requires a whole lot of small-scope ifndefs in the test file;
around 60 ifdefs in total for those both test files. Those could
be avoided if the CI environment could run with a newer version
of UCRT, but that's nontrivial to fix right away.)

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Feb 14 2022, 12:33 PM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 12:33 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Feb 16 2022, 1:18 PM
This revision is now accepted and ready to land.Feb 16 2022, 1:18 PM