This is an archive of the discontinued LLVM Phabricator instance.

Differential D119724

Fix test failure for targets with varying uwtable defaults
ClosedPublic

Authored by chill on Feb 14 2022, 7:43 AM.

Details

Reviewers
dmgreen
Commits
rGa31d00ddceb0: Fix test failure for targets with varying uwtable defaults
Summary

Depending on toolchain and ABI, a target might not output DWARF unwind tables by default.
Run the test for a target with a known behaviour, test coverage is not reduced.

Diff Detail

Event Timeline

chill requested review of this revision.Feb 14 2022, 7:43 AM
chill created this revision.
dmgreen accepted this revision.Feb 14 2022, 7:46 AM
dmgreen added a subscriber: dmgreen.

I think if you are just fixing buildbots, this kind of thing doesn't need review. LGTM is either case :)

This revision is now accepted and ready to land.Feb 14 2022, 7:46 AM
This revision was landed with ongoing or failed builds.Feb 14 2022, 8:00 AM
Closed by commit rGa31d00ddceb0: Fix test failure for targets with varying uwtable defaults (authored by chill). · Explain Why
This revision was automatically updated to reflect the committed changes.
chill added a commit: rGa31d00ddceb0: Fix test failure for targets with varying uwtable defaults.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 8:00 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B149388: Diff 408420.Feb 14 2022, 8:29 AM

Revision Contents

PathSize
clang/
test/
CodeGen/
14 lines

Diff 408420

clang/test/CodeGen/uwtable-attr.c

// Test that function and modules attributes react on the command-line options, // Test that function and modules attributes react on the command-line options,
// it does not state the current behaviour makes sense in all cases (it does not). // it does not state the current behaviour makes sense in all cases (it does not).
// RUN: %clang -S -emit-llvm -o - %s | FileCheck %s -check-prefixes=CHECK,DEFAULT // RUN: %clang -target x86_64-linux -S -emit-llvm -o - %s | FileCheck %s -check-prefixes=CHECK,DEFAULT
// RUN: %clang -S -emit-llvm -o - %s -funwind-tables -fno-asynchronous-unwind-tables | FileCheck %s -check-prefixes=CHECK,TABLES // RUN: %clang -target x86_64-linux -S -emit-llvm -o - %s -funwind-tables -fno-asynchronous-unwind-tables | FileCheck %s -check-prefixes=CHECK,TABLES
// RUN: %clang -S -emit-llvm -o - %s -fno-unwind-tables -fno-asynchronous-unwind-tables | FileCheck %s -check-prefixes=CHECK,NO_TABLES // RUN: %clang -target x86_64-linux -S -emit-llvm -o - %s -fno-unwind-tables -fno-asynchronous-unwind-tables | FileCheck %s -check-prefixes=CHECK,NO_TABLES
// RUN: %clang -S -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefixes=CHECK,DEFAULT // RUN: %clang -target x86_64-linux -S -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefixes=CHECK,DEFAULT
// RUN: %clang -S -emit-llvm -o - -x c++ %s -funwind-tables -fno-asynchronous-unwind-tables | FileCheck %s -check-prefixes=CHECK,TABLES // RUN: %clang -target x86_64-linux -S -emit-llvm -o - -x c++ %s -funwind-tables -fno-asynchronous-unwind-tables | FileCheck %s -check-prefixes=CHECK,TABLES
// RUN: %clang -S -emit-llvm -o - -x c++ %s -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables | FileCheck %s -check-prefixes=CHECK,NO_TABLES // RUN: %clang -target x86_64-linux -S -emit-llvm -o - -x c++ %s -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables | FileCheck %s -check-prefixes=CHECK,NO_TABLES
// REQUIRES: x86-registered-target
#ifdef __cplusplus #ifdef __cplusplus
extern "C" void g(void); extern "C" void g(void);
struct S { ~S(); }; struct S { ~S(); };
extern "C" int f() { S s; g(); return 0;}; extern "C" int f() { S s; g(); return 0;};
#else #else
void g(void); void g(void);
int f() { g(); return 0; }; int f() { g(); return 0; };
Show All 12 Lines