This is an archive of the discontinued LLVM Phabricator instance.

[HWASAN] regression test we do not instrument dynamic allocas
ClosedPublic

Authored by fmayer on Feb 11 2022, 4:34 PM.

Diff Detail

Event Timeline

fmayer requested review of this revision.Feb 11 2022, 4:34 PM
fmayer created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2022, 4:34 PM
fmayer updated this revision to Diff 408106.Feb 11 2022, 4:34 PM

remove unneeded checks

browneee accepted this revision.Feb 11 2022, 5:30 PM
browneee added inline comments.
llvm/test/Instrumentation/HWAddressSanitizer/alloca-uninteresting.ll
5

nit: I suggest a comment to explain the purpose of the test. e.g.

Test that no instrumentation is added for a dynamic sized alloca, which are not instrumented because ...

This revision is now accepted and ready to land.Feb 11 2022, 5:30 PM
This revision was landed with ongoing or failed builds.Feb 11 2022, 5:33 PM
This revision was automatically updated to reflect the committed changes.
fmayer marked an inline comment as done.