This is an archive of the discontinued LLVM Phabricator instance.

Differential D119569

Add support for the swift5 reflection section: accessible functions
ClosedPublic

Authored by rastogishubham on Feb 11 2022, 11:22 AM.

Details

Reviewers
aprantl
JDevlieghere
Commits
rGd76da6c7e445: Add support for the swift5 reflection section acfuncs
Summary

With bc013b3e4e862da8d0c2d91cf99dcbebf124e4ac a new section called accessible functions was added to swift/include/swift/ABI/ObjectFile.h so this change adds support for dumping it out into the dSYM bundle

Diff Detail

Event Timeline

rastogishubham requested review of this revision.Feb 11 2022, 11:22 AM
rastogishubham created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2022, 11:22 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
rastogishubham updated this revision to Diff 407969.Feb 11 2022, 11:26 AM

Add newline to Swift.def at the end of file

Harbormaster completed remote builds in B149041: Diff 407969.Feb 11 2022, 12:31 PM
JDevlieghere accepted this revision.Feb 11 2022, 12:37 PM

LGTM

This revision is now accepted and ready to land.Feb 11 2022, 12:37 PM
This revision was landed with ongoing or failed builds.Feb 11 2022, 2:05 PM
Closed by commit rGd76da6c7e445: Add support for the swift5 reflection section acfuncs (authored by rastogishubham). · Explain Why
This revision was automatically updated to reflect the committed changes.
rastogishubham added a commit: rGd76da6c7e445: Add support for the swift5 reflection section acfuncs.

Revision Contents

PathSize
llvm/
include/
llvm/
BinaryFormat/
2 lines
test/
tools/
dsymutil/
Inputs/
36 lines
X86/
3 lines

Diff 408047

llvm/include/llvm/BinaryFormat/Swift.def

Show All 22 Lines
HANDLE_SWIFT_SECTION(builtin, "__swift5_builtin", "swift5_builtin", ".sw5bltn") HANDLE_SWIFT_SECTION(builtin, "__swift5_builtin", "swift5_builtin", ".sw5bltn")
HANDLE_SWIFT_SECTION(capture, "__swift5_capture", "swift5_capture", ".sw5cptr") HANDLE_SWIFT_SECTION(capture, "__swift5_capture", "swift5_capture", ".sw5cptr")
HANDLE_SWIFT_SECTION(typeref, "__swift5_typeref", "swift5_typeref", ".sw5tyrf") HANDLE_SWIFT_SECTION(typeref, "__swift5_typeref", "swift5_typeref", ".sw5tyrf")
HANDLE_SWIFT_SECTION(reflstr, "__swift5_reflstr", "swift5_reflstr", ".sw5rfst") HANDLE_SWIFT_SECTION(reflstr, "__swift5_reflstr", "swift5_reflstr", ".sw5rfst")
HANDLE_SWIFT_SECTION(conform, "__swift5_proto", "swift5_protocol_confromances", HANDLE_SWIFT_SECTION(conform, "__swift5_proto", "swift5_protocol_confromances",
".sw5prtc$B") ".sw5prtc$B")
HANDLE_SWIFT_SECTION(protocs, "__swift5_protos", "swift5_protocols", HANDLE_SWIFT_SECTION(protocs, "__swift5_protos", "swift5_protocols",
".sw5prt$B") ".sw5prt$B")
HANDLE_SWIFT_SECTION(acfuncs, "__swift5_acfuncs", "swift5_accessible_functions",
".sw5acfn$B")

llvm/test/tools/dsymutil/Inputs/reflection_metadata.yaml

Show All 10 Lines
--- !mach-o --- !mach-o
FileHeader: FileHeader:
magic: 0xFEEDFACF magic: 0xFEEDFACF
cputype: 0x1000007 cputype: 0x1000007
cpusubtype: 0x3 cpusubtype: 0x3
filetype: 0x1 filetype: 0x1
ncmds: 8 ncmds: 8
sizeofcmds: 2960 sizeofcmds: 3040
flags: 0x2000 flags: 0x2000
reserved: 0x0 reserved: 0x0
LoadCommands: LoadCommands:
- cmd: LC_SEGMENT_64 - cmd: LC_SEGMENT_64
cmdsize: 2712 cmdsize: 2792
segname: '' segname: ''
vmaddr: 0 vmaddr: 0
vmsize: 21352 vmsize: 21352
fileoff: 2832 fileoff: 2832
filesize: 20967 filesize: 20967
maxprot: 7 maxprot: 7
initprot: 7 initprot: 7
nsects: 33 nsects: 33
flags: 0 flags: 0
Sections: Sections:
- sectname: __text - sectname: __text
segname: __TEXT segname: __TEXT
addr: 0x0 addr: 0x0
size: 4571 size: 4571
offset: 0xBB0 offset: 0xC00
align: 4 align: 4
reloff: 0x5CF8 reloff: 0x5CF8
nreloc: 74 nreloc: 74
flags: 0x80000400 flags: 0x80000400
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
relocations: relocations:
- address: 0x11A1 - address: 0x11A1
symbolnum: 142 symbolnum: 142
pcrel: true pcrel: true
length: 2 length: 2
extern: true extern: true
type: 1 type: 1
scattered: false scattered: false
value: 0 value: 0
- sectname: __swift5_typeref - sectname: __swift5_typeref
segname: __TEXT segname: __TEXT
addr: 0x11DC addr: 0x11DC
size: 117 size: 117
offset: 0x1D8C offset: 0x1DDC
align: 1 align: 1
reloff: 0x5F48 reloff: 0x5F48
nreloc: 22 nreloc: 22
flags: 0x10000000 flags: 0x10000000
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
content: 7800423000005369000001FFFFFFFF002473346D61696E31304D7950726F746F636F6C50000001FFFFFFFF0001FFFFFFFF0001FFFFFFFF0001FFFFFFFF0035496E6E657201F9FFFFFF517A0001FFFFFFFF797847000001FFFFFFFF797847000001FFFFFFFF0001FFFFFFFF0001FFFFFFFF79784700 content: 7800423000005369000001FFFFFFFF002473346D61696E31304D7950726F746F636F6C50000001FFFFFFFF0001FFFFFFFF0001FFFFFFFF0001FFFFFFFF0035496E6E657201F9FFFFFF517A0001FFFFFFFF797847000001FFFFFFFF797847000001FFFFFFFF0001FFFFFFFF0001FFFFFFFF79784700
relocations: relocations:
- address: 0x6D - address: 0x6D
symbolnum: 163 symbolnum: 163
pcrel: false pcrel: false
length: 2 length: 2
extern: true extern: true
type: 0 type: 0
scattered: false scattered: false
value: 0 value: 0
- sectname: __swift5_capture - sectname: __swift5_capture
segname: __TEXT segname: __TEXT
addr: 0x1254 addr: 0x1254
size: 24 size: 24
offset: 0x1E04 offset: 0x1E54
align: 2 align: 2
reloff: 0x5FF8 reloff: 0x5FF8
nreloc: 6 nreloc: 6
flags: 0x10000000 flags: 0x10000000
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
content: 010000000100000002000000F4FFFFFFF0FFFFFFECFFFFFF content: 010000000100000002000000F4FFFFFFF0FFFFFFECFFFFFF
relocations: relocations:
- address: 0x14 - address: 0x14
symbolnum: 29 symbolnum: 29
pcrel: false pcrel: false
length: 3 length: 3
extern: true extern: true
type: 0 type: 0
scattered: false scattered: false
value: 0 value: 0
- sectname: __swift5_reflstr - sectname: __swift5_reflstr
segname: __TEXT segname: __TEXT
addr: 0x17D8 addr: 0x17D8
size: 37 size: 37
offset: 0x2388 offset: 0x23D8
align: 0 align: 0
reloff: 0x0 reloff: 0x0
nreloc: 0 nreloc: 0
flags: 0x10000000 flags: 0x10000000
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
content: 496E6E65720069006D73006D6500696E6E6572004300490074006D6773006D676500474300 content: 496E6E65720069006D73006D6500696E6E6572004300490074006D6773006D676500474300
- sectname: __swift5_assocty - sectname: __swift5_assocty
segname: __TEXT segname: __TEXT
addr: 0x1800 addr: 0x1800
size: 24 size: 24
offset: 0x23B0 offset: 0x2400
align: 2 align: 2
reloff: 0x6530 reloff: 0x6530
nreloc: 8 nreloc: 8
flags: 0x10000000 flags: 0x10000000
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
content: 00000000FCFFFFFF0100000008000000F0FFFFFFECFFFFFF content: 00000000FCFFFFFF0100000008000000F0FFFFFFECFFFFFF
relocations: relocations:
- address: 0x14 - address: 0x14
symbolnum: 31 symbolnum: 31
pcrel: false pcrel: false
length: 2 length: 2
extern: true extern: true
type: 5 type: 5
scattered: false scattered: false
value: 0 value: 0
- sectname: __swift5_fieldmd - sectname: __swift5_fieldmd
segname: __TEXT segname: __TEXT
addr: 0x1818 addr: 0x1818
size: 260 size: 260
offset: 0x23C8 offset: 0x2418
align: 2 align: 2
reloff: 0x6570 reloff: 0x6570
nreloc: 60 nreloc: 60
flags: 0x10000000 flags: 0x10000000
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
content: 000000000000000004000C0000000000000000000000000001000C000300000000000000ECFFFFFFE8FFFFFF00000000E0FFFFFFDCFFFFFF00000000D4FFFFFFD0FFFFFF000000000000000000000C000100000002000000ECFFFFFFE8FFFFFF000000000000000000000C0000000000000000000000000003000C000200000000000000ECFFFFFFE8FFFFFF00000000E0FFFFFFDCFFFFFF000000000000000001000C000400000000000000ECFFFFFFE8FFFFFF00000000E0FFFFFFDCFFFFFF00000000D4FFFFFFD0FFFFFF00000000C8FFFFFFC4FFFFFF000000000000000000000C0000000000000000000000000002000C000100000000000000ECFFFFFFE8FFFFFF content: 000000000000000004000C0000000000000000000000000001000C000300000000000000ECFFFFFFE8FFFFFF00000000E0FFFFFFDCFFFFFF00000000D4FFFFFFD0FFFFFF000000000000000000000C000100000002000000ECFFFFFFE8FFFFFF000000000000000000000C0000000000000000000000000003000C000200000000000000ECFFFFFFE8FFFFFF00000000E0FFFFFFDCFFFFFF000000000000000001000C000400000000000000ECFFFFFFE8FFFFFF00000000E0FFFFFFDCFFFFFF00000000D4FFFFFFD0FFFFFF00000000C8FFFFFFC4FFFFFF000000000000000000000C0000000000000000000000000002000C000100000000000000ECFFFFFFE8FFFFFF
relocations: relocations:
- address: 0x100 - address: 0x100
symbolnum: 71 symbolnum: 71
pcrel: false pcrel: false
length: 2 length: 2
extern: true extern: true
type: 0 type: 0
scattered: false scattered: false
value: 0 value: 0
- sectname: __swift5_builtin - sectname: __swift5_builtin
segname: __TEXT segname: __TEXT
addr: 0x1AC8 addr: 0x1AC8
size: 20 size: 20
offset: 0x2678 offset: 0x26C8
align: 2 align: 2
reloff: 0x67F8 reloff: 0x67F8
nreloc: 2 nreloc: 2
flags: 0x10000000 flags: 0x10000000
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
content: 00000000090000000800010010000000FE000000 content: 00000000090000000800010010000000FE000000
relocations: relocations:
- address: 0x0 - address: 0x0
symbolnum: 52 symbolnum: 52
pcrel: false pcrel: false
length: 2 length: 2
extern: true extern: true
type: 5 type: 5
scattered: false scattered: false
value: 0 value: 0
- sectname: __swift5_proto - sectname: __swift5_proto
segname: __TEXT segname: __TEXT
addr: 0x1AEC addr: 0x1AEC
size: 10 size: 10
offset: 0x269C offset: 0x26EC
align: 2 align: 2
reloff: 0x0 reloff: 0x0
nreloc: 0 nreloc: 0
flags: 0x10000000 flags: 0x10000000
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
content: 41424344454647484950 content: 41424344454647484950
- sectname: __swift5_protos - sectname: __swift5_protos
segname: __TEXT segname: __TEXT
addr: 0x1AF8 addr: 0x1AF8
size: 10 size: 10
offset: 0x26C0 offset: 0x2710
align: 2 align: 2
reloff: 0x0 reloff: 0x0
nreloc: 0 nreloc: 0
flags: 0x10000000 flags: 0x10000000
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
content: 51525354555657585960 content: 51525354555657585960
- sectname: __swift5_acfuncs
segname: __TEXT
addr: 0x1B04
size: 10
offset: 0x2734
align: 2
reloff: 0x0
nreloc: 0
flags: 0x10000000
reserved1: 0x0
reserved2: 0x0
content: 61626364656667686970
- sectname: __bss - sectname: __bss
segname: __DATA segname: __DATA
addr: 0x3372 addr: 0x3372
size: 2084 size: 2084
offset: 0x5150 offset: 0x51D0
align: 3 align: 3
reloff: 0x0 reloff: 0x0
nreloc: 0 nreloc: 0
flags: 0x6800000B flags: 0x6800000B
reserved1: 0x0 reserved1: 0x0
reserved2: 0x0 reserved2: 0x0
relocations: relocations:
- address: 0x56 - address: 0x56
▲ Show 20 Lines • Show All 252 Lines • Show Last 20 Lines

llvm/test/tools/dsymutil/X86/reflection-dump.test

Show First 20 Lines • Show All 42 Lines • ▼ Show 20 Lines
CHECK-NEXT: 10000e244 00000000 09000000 08000100 10000000 ................ CHECK-NEXT: 10000e244 00000000 09000000 08000100 10000000 ................
CHECK-NEXT: 10000e254 fe000000 .... CHECK-NEXT: 10000e254 fe000000 ....
CHECK: Contents of section __DWARF,__swift5_proto: CHECK: Contents of section __DWARF,__swift5_proto:
CHECK-NEXT: 10000e258 41424344 45464748 4950 ABCDEFGHIP CHECK-NEXT: 10000e258 41424344 45464748 4950 ABCDEFGHIP
CHECK: Contents of section __DWARF,__swift5_protos: CHECK: Contents of section __DWARF,__swift5_protos:
CHECK-NEXT: 10000e264 51525354 55565758 5960 QRSTUVWXY` CHECK-NEXT: 10000e264 51525354 55565758 5960 QRSTUVWXY`
CHECK: Contents of section __DWARF,__swift5_acfuncs:
CHECK-NEXT: 10000e270 61626364 65666768 6970 abcdefghip