Page MenuHomePhabricator
Differential D119466

[libc++abi] Add a from-scratch testing config for Apple backdeployment
ClosedPublic
Actions

Authored by ldionne on Feb 10 2022, 11:56 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Restricted Project
Commits
rG8c060613721c: [libc++abi] Add a from-scratch testing config for Apple backdeployment
Summary

We added one for libc++ recently, and this patch adds one for libc++abi.
Also, as a fly-by fix, include older libunwind dylibs in the testing of
libc++ and libc++abi, which fixes some issues related to running
back-deployment tests on newer systems.

Diff Detail

Unit TestsFailed
View All

TimeTest
30 mslibcxx CI MacOS x86_64 > libc++abi.libc++abi::test_exception_address_alignment.pass.cpp
Script: -- : 'COMPILED WITH'; /Library/Developer/CommandLineTools/usr/bin/c++ /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com-1/llvm-project/libcxx-ci/libcxxabi/test/test_exception_address_alignment.pass.cpp -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -v --target=x86_64-apple-darwin19.6.0 -D_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS -funwind-tables -nostdinc++ -I/Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com-1/llvm-project/libcxx-ci/build/generic-cxx20/include/c++/v1 -I/Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com-1/llvm-project/libcxx-ci/libcxxabi/../libcxx/src -I/Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com-1/llvm-project/libcxx-ci/libcxxabi/include -I/Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com-1/llvm-project/libcxx-ci/libcxxabi/../libcxx/test/support -std=c++2a -Werror -Wall -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-user-defined-literals -Wno-noexcept-type -Wno-atomic-alignment -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_DISABLE_AVAILABILITY -fcoroutines-ts -Werror=thread-safety -Wuser-defined-warnings -L/Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com-1/llvm-project/libcxx-ci/build/generic-cxx20/lib -Wl,-rpath,/Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com-1/llvm-project/libcxx-ci/build/generic-cxx20/lib -L/Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com-1/llvm-project/libcxx-ci/build/generic-cxx20/lib -Wl,-rpath,/Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8-macminivault-com-1/llvm-project/libcxx-ci/build/generic-cxx20/lib -nodefaultlibs -lc++ -lc++abi -lSystem -o /Users/libcxx-buildkite-agent/libcxx.buildkite-agent/builds/y10-8…

Event Timeline

ldionne created this revision.Feb 10 2022, 11:56 AM
Herald added a subscriber: arichardson. · View Herald TranscriptFeb 10 2022, 11:56 AM
ldionne requested review of this revision.Feb 10 2022, 11:56 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 10 2022, 11:56 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B148807: Diff 407627.Feb 10 2022, 5:41 PM
ldionne updated this revision to Diff 408471.Feb 14 2022, 9:53 AM

Try to fix CI. Note that the buildkite pipeline edit is only to avoid wasting CI resources

Herald added a subscriber: mstorsjo. · View Herald TranscriptFeb 14 2022, 9:53 AM
Harbormaster completed remote builds in B149423: Diff 408471.Feb 14 2022, 11:47 AM
ldionne updated this revision to Diff 408568.Feb 14 2022, 12:36 PM
ldionne edited the summary of this revision. (Show Details)

Update with final version of the patch.

ldionne accepted this revision.Feb 14 2022, 12:36 PM

I'll ship this right away since it already passed all the relevant CI.

This revision is now accepted and ready to land.Feb 14 2022, 12:36 PM
This revision was landed with ongoing or failed builds.Feb 14 2022, 12:37 PM
Closed by commit rG8c060613721c: [libc++abi] Add a from-scratch testing config for Apple backdeployment (authored by ldionne). · Explain Why
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG8c060613721c: [libc++abi] Add a from-scratch testing config for Apple backdeployment.
Harbormaster completed remote builds in B149485: Diff 408568.Feb 14 2022, 4:53 PM

Revision Contents
Changeset List

PathSize
libcxx/
test/
configs/
11 lines
utils/
ci/
3 lines
libcxxabi/
test/
configs/
libcxx/
test/
configs/
apple-libc++abi-backdeployment.cfg.in
apple-libc++-backdeployment.cfg.in
24 lines
libcxxabi/
test/
5 lines

Diff 408568

View Options

libcxx/test/configs/apple-libc++-backdeployment.cfg.in

Loading...
View Options

libcxx/utils/ci/run-buildbot

Loading...
View Options

libcxxabi/test/configs/apple-libc++abi-backdeployment.cfg.in

Loading...
View Options

libcxxabi/test/test_exception_address_alignment.pass.cpp

Loading...