This is an archive of the discontinued LLVM Phabricator instance.

Differential D119446

[clang-cl] Accept the "legacy'"-target flag spelling
ClosedPublic

Authored by hans on Feb 10 2022, 8:22 AM.

Details

Reviewers
thakis
Commits
rG8baa076dffa3: [clang-cl] Accept the "legacy" -target flag spelling
Summary

we already accept "--target=". No reason to not accept "-target" too (that's the one I typically use for some reason).

Diff Detail

Event Timeline

hans created this revision.Feb 10 2022, 8:22 AM
Herald added a subscriber: dang. · View Herald TranscriptFeb 10 2022, 8:22 AM
hans requested review of this revision.Feb 10 2022, 8:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2022, 8:22 AM
Harbormaster completed remote builds in B148754: Diff 407545.Feb 10 2022, 8:23 AM
thakis accepted this revision.Feb 10 2022, 8:26 AM

lg!

This revision is now accepted and ready to land.Feb 10 2022, 8:26 AM
This revision was landed with ongoing or failed builds.Feb 10 2022, 9:27 AM
Closed by commit rG8baa076dffa3: [clang-cl] Accept the "legacy" -target flag spelling (authored by hans). · Explain Why
This revision was automatically updated to reflect the committed changes.
hans added a commit: rG8baa076dffa3: [clang-cl] Accept the "legacy" -target flag spelling.
thakis mentioned this in D119612: [clang] Pass more flags to ld64.lld.Feb 16 2022, 7:23 AM

Revision Contents

PathSize
clang/
include/
clang/
Driver/
4 lines
test/
Driver/
5 lines

Diff 407545

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 4,436 Lines • ▼ Show 20 Lines
def mretpoline_external_thunk : Flag<["-"], "mretpoline-external-thunk">, Group<m_x86_Features_Group>; def mretpoline_external_thunk : Flag<["-"], "mretpoline-external-thunk">, Group<m_x86_Features_Group>;
def mno_retpoline_external_thunk : Flag<["-"], "mno-retpoline-external-thunk">, Group<m_x86_Features_Group>; def mno_retpoline_external_thunk : Flag<["-"], "mno-retpoline-external-thunk">, Group<m_x86_Features_Group>;
def mvzeroupper : Flag<["-"], "mvzeroupper">, Group<m_x86_Features_Group>; def mvzeroupper : Flag<["-"], "mvzeroupper">, Group<m_x86_Features_Group>;
def mno_vzeroupper : Flag<["-"], "mno-vzeroupper">, Group<m_x86_Features_Group>; def mno_vzeroupper : Flag<["-"], "mno-vzeroupper">, Group<m_x86_Features_Group>;
// These are legacy user-facing driver-level option spellings. They are always // These are legacy user-facing driver-level option spellings. They are always
// aliases for options that are spelled using the more common Unix / GNU flag // aliases for options that are spelled using the more common Unix / GNU flag
// style of double-dash and equals-joined flags. // style of double-dash and equals-joined flags.
def target_legacy_spelling : Separate<["-"], "target">, Alias<target>; def target_legacy_spelling : Separate<["-"], "target">,
Alias<target>,
Flags<[CoreOption]>;
// Special internal option to handle -Xlinker --no-demangle. // Special internal option to handle -Xlinker --no-demangle.
def Z_Xlinker__no_demangle : Flag<["-"], "Z-Xlinker-no-demangle">, def Z_Xlinker__no_demangle : Flag<["-"], "Z-Xlinker-no-demangle">,
Flags<[Unsupported, NoArgumentUnused]>; Flags<[Unsupported, NoArgumentUnused]>;
// Special internal option to allow forwarding arbitrary arguments to linker. // Special internal option to allow forwarding arbitrary arguments to linker.
def Zlinker_input : Separate<["-"], "Zlinker-input">, def Zlinker_input : Separate<["-"], "Zlinker-input">,
Flags<[Unsupported, NoArgumentUnused]>; Flags<[Unsupported, NoArgumentUnused]>;
▲ Show 20 Lines • Show All 2,086 Lines • Show Last 20 Lines

clang/test/Driver/cl-options.c

Show First 20 Lines • Show All 766 Lines • ▼ Show 20 Lines
// FAKEDIR: "-internal-isystem" "/foo{{/|\\\\}}Include{{/|\\\\}}10.0.12345.0{{/|\\\\}}shared" // FAKEDIR: "-internal-isystem" "/foo{{/|\\\\}}Include{{/|\\\\}}10.0.12345.0{{/|\\\\}}shared"
// FAKEDIR: "-internal-isystem" "/foo{{/|\\\\}}Include{{/|\\\\}}10.0.12345.0{{/|\\\\}}um" // FAKEDIR: "-internal-isystem" "/foo{{/|\\\\}}Include{{/|\\\\}}10.0.12345.0{{/|\\\\}}um"
// FAKEDIR: "-internal-isystem" "/foo{{/|\\\\}}Include{{/|\\\\}}10.0.12345.0{{/|\\\\}}winrt" // FAKEDIR: "-internal-isystem" "/foo{{/|\\\\}}Include{{/|\\\\}}10.0.12345.0{{/|\\\\}}winrt"
// FAKEDIR: "-libpath:/fake{{/|\\\\}}lib{{/|\\\\}} // FAKEDIR: "-libpath:/fake{{/|\\\\}}lib{{/|\\\\}}
// FAKEDIR: "-libpath:/fake{{/|\\\\}}atlmfc{{/|\\\\}}lib{{/|\\\\}} // FAKEDIR: "-libpath:/fake{{/|\\\\}}atlmfc{{/|\\\\}}lib{{/|\\\\}}
// FAKEDIR: "-libpath:/foo{{/|\\\\}}Lib{{/|\\\\}}10.0.12345.0{{/|\\\\}}ucrt // FAKEDIR: "-libpath:/foo{{/|\\\\}}Lib{{/|\\\\}}10.0.12345.0{{/|\\\\}}ucrt
// FAKEDIR: "-libpath:/foo{{/|\\\\}}Lib{{/|\\\\}}10.0.12345.0{{/|\\\\}}um // FAKEDIR: "-libpath:/foo{{/|\\\\}}Lib{{/|\\\\}}10.0.12345.0{{/|\\\\}}um
// Accept both the -target and --target= spellings.
// RUN: %clang_cl --target=i686-pc-windows-msvc19.14.0 -### -- %s 2>&1 | FileCheck -check-prefix=TARGET %s
// RUN: %clang_cl -target i686-pc-windows-msvc19.14.0 -### -- %s 2>&1 | FileCheck -check-prefix=TARGET %s
// TARGET: "-triple" "i686-pc-windows-msvc19.14.0"
void f() { } void f() { }