This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add LWG-issues from february 2022 plenary meeting
ClosedPublic

Authored by philnik on Feb 10 2022, 7:47 AM.

Diff Detail

Event Timeline

philnik requested review of this revision.Feb 10 2022, 7:47 AM
philnik created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2022, 7:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Feb 10 2022, 7:58 AM

Thanks!

This revision is now accepted and ready to land.Feb 10 2022, 7:58 AM
Quuxplusone accepted this revision.Feb 10 2022, 9:03 AM

LGTM, with some easy things to cross off the list.

libcxx/docs/Status/Cxx2bIssues.csv
145

|Nothing To Do| for LWG3607; it affects semantic requirements only.

156

|Nothing To Do| on LWG3650.

159

|Complete| in 14.0 for LWG3660.

ldionne added inline comments.Feb 10 2022, 9:07 AM
libcxx/docs/Status/Cxx2bIssues.csv
159

When did we implement this one?

Mordante accepted this revision.Feb 10 2022, 9:17 AM

Thanks for doing this, LGTM!

philnik updated this revision to Diff 407576.Feb 10 2022, 9:29 AM
philnik marked 3 inline comments as done.
  • Mark more issues as complete/nothing to do
libcxx/docs/Status/Cxx2bIssues.csv
159

I believe this has always been implemented. It was kind of a wording bug: the wording said iterator_traits<C>::pointer was "the type of" c.operator->(), but in fact everyone was implementing it as decltype(c.operator->()) (which might be a reference type). And yes that's crazy, that pointer can (now conformingly) be a reference type; but nobody cares about pointer anyway.

This revision was landed with ongoing or failed builds.Feb 10 2022, 2:21 PM
This revision was automatically updated to reflect the committed changes.