Refactor nested if else with ternary operator in CGExprScalar.cpp

[rjmccall]

Sure, LGTM

[phyBrackets]

This comment was removed by phyBrackets.

[phyBrackets]

In D119364#3310170, @rjmccall wrote:

Sure, LGTM

Hey Thanks, would you please help to land this patch . I don't have commit access .

[phyBrackets]

Hey @rjmccall , would you tell me about this build fail https://green.lab.llvm.org/green/job/lldb-cmake/41339/

[rjmccall]

It's nothing to do with your patch, and you don't need to worry about it.

clang/lib/CodeGen/CGExprScalar.cpp

 bool mayHaveIntegerOverflow(llvm::ConstantInt *LHS, llvm::ConstantInt *RHS,
                              BinaryOperator::Opcode Opcode, bool Signed,
                              llvm::APInt &Result) {
   // Assume overflow is possible, unless we can prove otherwise.
   bool Overflow = true;
   const auto &LHSAP = LHS->getValue();
   const auto &RHSAP = RHS->getValue();
   if (Opcode == BO_Add) {
-    if (Signed)
-      Result = LHSAP.sadd_ov(RHSAP, Overflow);
-    else
-      Result = LHSAP.uadd_ov(RHSAP, Overflow);
+    Result = Signed ? LHSAP.sadd_ov(RHSAP, Overflow)
+                    : LHSAP.uadd_ov(RHSAP, Overflow);
   } else if (Opcode == BO_Sub) {
-    if (Signed)
-      Result = LHSAP.ssub_ov(RHSAP, Overflow);
-    else
-      Result = LHSAP.usub_ov(RHSAP, Overflow);
+    Result = Signed ? LHSAP.ssub_ov(RHSAP, Overflow)
+                    : LHSAP.usub_ov(RHSAP, Overflow);
   } else if (Opcode == BO_Mul) {
-    if (Signed)
-      Result = LHSAP.smul_ov(RHSAP, Overflow);
-    else
-      Result = LHSAP.umul_ov(RHSAP, Overflow);
+    Result = Signed ? LHSAP.smul_ov(RHSAP, Overflow)
+                    : LHSAP.umul_ov(RHSAP, Overflow);
   } else if (Opcode == BO_Div || Opcode == BO_Rem) {
     if (Signed && !RHS->isZero())
       Result = LHSAP.sdiv_ov(RHSAP, Overflow);
     else
       return false;
   }
   return Overflow;
 }