This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Fix the aligned storage test to work on Windows
ClosedPublic

Authored by mstorsjo on Feb 9 2022, 8:50 AM.

Details

Summary

Don't test alignment over 8 KB, which isn't supported on that
platform.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Feb 9 2022, 8:50 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2022, 8:50 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Quuxplusone added inline comments.
libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/aligned_storage.pass.cpp
315

Can you add a test case right above this one, for Align=8192, then?

mstorsjo updated this revision to Diff 407179.Feb 9 2022, 9:04 AM

Added testing of specifically 8K alignment.

Mordante accepted this revision as: Mordante.Feb 9 2022, 9:26 AM
Mordante added a subscriber: Mordante.

LGTM!

Quuxplusone accepted this revision.Feb 9 2022, 12:14 PM

The ASAN CI failure must be unrelated.

This revision is now accepted and ready to land.Feb 9 2022, 12:14 PM
This revision was landed with ongoing or failed builds.Feb 10 2022, 1:00 AM
This revision was automatically updated to reflect the committed changes.