This is an archive of the discontinued LLVM Phabricator instance.

Differential D119265

[libc][Obvious] Fix typo in mkdir and mkdirat implementations.
ClosedPublic

Authored by sivachandra on Feb 8 2022, 10:54 AM.

Details

Reviewers
michaelrj
lntue
Commits
rG545331abf379: [libc][Obvious] Fix typo in mkdir and mkdirat implementations.

Diff Detail

Event Timeline

sivachandra created this revision.Feb 8 2022, 10:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 8 2022, 10:54 AM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
sivachandra requested review of this revision.Feb 8 2022, 10:54 AM
Harbormaster completed remote builds in B148301: Diff 406897.Feb 8 2022, 10:58 AM
lntue accepted this revision.Feb 8 2022, 11:35 AM
This revision is now accepted and ready to land.Feb 8 2022, 11:35 AM
Closed by commit rG545331abf379: [libc][Obvious] Fix typo in mkdir and mkdirat implementations. (authored by sivachandra). · Explain WhyFeb 8 2022, 1:48 PM
This revision was automatically updated to reflect the committed changes.
sivachandra added a commit: rG545331abf379: [libc][Obvious] Fix typo in mkdir and mkdirat implementations..

Revision Contents

PathSize
libc/
src/
sys/
stat/
linux/
2 lines
2 lines

Diff 406961

libc/src/sys/stat/linux/mkdir.cpp

Show All 15 Lines
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/syscall.h> // For syscall numbers. #include <sys/syscall.h> // For syscall numbers.
namespace __llvm_libc { namespace __llvm_libc {
LLVM_LIBC_FUNCTION(int, mkdir, (const char *path, mode_t mode)) { LLVM_LIBC_FUNCTION(int, mkdir, (const char *path, mode_t mode)) {
#ifdef SYS_mkdir #ifdef SYS_mkdir
long ret = __llvm_libc::syscall(SYS_mkdir, path, mode); long ret = __llvm_libc::syscall(SYS_mkdir, path, mode);
#elif defined(SYS_unlinkat) #elif defined(SYS_mkdirat)
long ret = __llvm_libc::syscall(SYS_mkdirat, AT_FDCWD, path, mode); long ret = __llvm_libc::syscall(SYS_mkdirat, AT_FDCWD, path, mode);
#else #else
#error "mkdir and mkdirat syscalls not available." #error "mkdir and mkdirat syscalls not available."
#endif #endif
if (ret < 0) { if (ret < 0) {
errno = -ret; errno = -ret;
return -1; return -1;
} }
return 0; return 0;
} }
} // namespace __llvm_libc } // namespace __llvm_libc

libc/src/sys/stat/linux/mkdirat.cpp

Show All 12 Lines
#include <errno.h> #include <errno.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/syscall.h> // For syscall numbers. #include <sys/syscall.h> // For syscall numbers.
namespace __llvm_libc { namespace __llvm_libc {
LLVM_LIBC_FUNCTION(int, mkdirat, (int dfd, const char *path, mode_t mode)) { LLVM_LIBC_FUNCTION(int, mkdirat, (int dfd, const char *path, mode_t mode)) {
#ifdef SYS_unlinkat #ifdef SYS_mkdirat
long ret = __llvm_libc::syscall(SYS_mkdirat, dfd, path, mode); long ret = __llvm_libc::syscall(SYS_mkdirat, dfd, path, mode);
#else #else
#error "mkdirat syscalls not available." #error "mkdirat syscalls not available."
#endif #endif
if (ret < 0) { if (ret < 0) {
errno = -ret; errno = -ret;
return -1; return -1;
} }
return 0; return 0;
} }
} // namespace __llvm_libc } // namespace __llvm_libc