[clang-format] Honour "// clang-format off" when using QualifierOrder.

[curdeius]

Summary

Fixes https://github.com/llvm/llvm-project/issues/53643.

[HazardyKnusperkeks]

Let's me wonder if it was respected in the block separator...

clang/unittests/Format/QualifierFixerTest.cpp

879

Shouldn't this be sorted?

[curdeius]

clang/unittests/Format/QualifierFixerTest.cpp

875

It's sorted here.

879

This is input code, not the expected result.

[MyDeveloperDay]

Perfect thank you

[HazardyKnusperkeks]

clang/unittests/Format/QualifierFixerTest.cpp

879

I've not seen the comma, I thought there is only 1 string.

clang/lib/Format/QualifierAlignmentFixer.cpp

LeftRightQualifierAlignmentFixer::analyze(
   const SourceManager &SourceMgr = Env.getSourceManager();
   AffectedRangeMgr.computeAffectedLines(AnnotatedLines);
 
   tok::TokenKind QualifierToken = getTokenFromQualifier(Qualifier);
   assert(QualifierToken != tok::identifier && "Unrecognised Qualifier");
 
   for (AnnotatedLine *Line : AnnotatedLines) {
     FormatToken *First = Line->First;
+    assert(First);
+    if (First->Finalized)
+      continue;
+
     const auto *Last = Line->Last;
 
     for (const auto *Tok = First; Tok && Tok != Last && Tok->Next;
          Tok = Tok->Next) {
       if (Tok->is(tok::comment))
         continue;
       if (RightAlign)
         Tok = analyzeRight(SourceMgr, Keywords, Fixes, Tok, Qualifier,

clang/unittests/Format/QualifierFixerTest.cpp

TEST_F(QualifierFixerTest, QualifierTemplates) {
   verifyFormat("template <class C> using A = /**/ B<Foo<C>, 1>;", Style);
   EXPECT_EQ(ReplacementCount, 0);
   verifyFormat("template <class C>\n"
                "using A = B // foo\n"
                "    <Foo<C>, 1>;",
                Style);
 }
 
+TEST_F(QualifierFixerTest, DisableRegions) {
+  FormatStyle Style = getLLVMStyle();
+  Style.QualifierAlignment = FormatStyle::QAS_Custom;
+  Style.QualifierOrder = {"inline", "static", "const", "type"};
+
+  ReplacementCount = 0;
+  verifyFormat("// clang-format off\n"
+               "int const inline static a = 0;\n"
+               "// clang-format on\n",
+               Style);
+  EXPECT_EQ(ReplacementCount, 0);
+  verifyFormat("// clang-format off\n"
+               "int const inline static a = 0;\n"
+               "// clang-format on\n"
+               "inline static const int a = 0;\n",
+               "// clang-format off\n"
+               "int const inline static a = 0;\n"
+               "// clang-format on\n"
+               "int const inline static a = 0;\n",
+               Style);
+}
+
 } // namespace format
 } // namespace clang