This is an archive of the discontinued LLVM Phabricator instance.

[SampleFDO] Enable FSAFDO loading passes if --enable-fs-discriminator is enabled
ClosedPublic

Authored by xur on Feb 4 2022, 12:51 PM.

Details

Summary

FSAFDO profile loader is currently disabled even --enable-fs-discriminator is enabled.
They need to be turned on by options which makes it cumbersome for experiments.

This patch changes the FSAFDO profile loader enabled by default. Since they are
guarded by EnableFSDiscriminator, they will only be turned on if
--enable-fs-discriminator is enabled. Note that --enable-fs-discriminator is
still disabled by default.

Diff Detail

Event Timeline

xur created this revision.Feb 4 2022, 12:51 PM
xur requested review of this revision.Feb 4 2022, 12:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2022, 12:51 PM
hoy accepted this revision.Feb 4 2022, 3:53 PM

LGTM.

This revision is now accepted and ready to land.Feb 4 2022, 3:53 PM
wenlei accepted this revision.Feb 4 2022, 6:41 PM
This revision was landed with ongoing or failed builds.Feb 5 2022, 10:38 PM
This revision was automatically updated to reflect the committed changes.